Skip to contentSkip to conversation

tools build: Fix removal of feature-sync-compare-and-swap feature detection

PATCH New Arnaldo Carvalho de Melo 1 participant 1 message Nov 17, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools build: Fix removal of feature-sync-compare-and-swap feature detection

The patch removing the feature-sync-compare-and-swap feature detection didn't remove the call to main_test_sync_compare_and_swap(), making the 'test-all' case fail an all the feature tests to be performed individually:

  $ cat /tmp/build/perf/feature/test-all.make.output
  In file included from test-all.c:18:
  test-libpython-version.c:5:10: error: #error
      5 |         #error
        |          ^~~~~
  test-all.c: In function ‘main’:
  test-all.c:203:9: error: implicit declaration of function ‘main_test_sync_compare_and_swap’ [-Werror=implicit-function-declaration]
    203 |         main_test_sync_compare_and_swap(argc, argv);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors
  $

Fix it, now to figure out what is that test-libpython-version.c problem...

Fixes 60fa754b2a5a4e0c ("tools: Remove feature-sync-compare-and-swap feature detection")
Cc Jiri Olsa <[email protected]>
Cc Leo Yan <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Mathieu Poirier <[email protected]>
Cc Mike Leach <[email protected]>
Cc Namhyung Kim <[email protected]>
---
 tools/build/feature/test-all.c | 1 -
 1 file changed, 1 deletion(-)
tools/build/feature/test-all.c +0 -1
index 9204395272912c13..0b243ce842be3383 100644
@@ -200,7 +200,6 @@ int main(int argc, char *argv[])
 	main_test_timerfd();
 	main_test_stackprotector_all();
 	main_test_libdw_dwarf_unwind();
-	main_test_sync_compare_and_swap(argc, argv);
 	main_test_zlib();
 	main_test_pthread_attr_setaffinity_np();
 	main_test_pthread_barrier();
Signature · 1 line
2.31.1