Skip to contentSkip to conversation

regulator: rohm-generic: iniline stub function

PATCH In review Matti Vaittinen 2 participants 2 messages Nov 23, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: rohm-generic: iniline stub function

The function rohm_regulator_set_voltage_sel_restricted() has a stub implementation. Linux-next testing spot following:

include/linux/mfd/rohm-generic.h:93:12: error:
'rohm_regulator_set_voltage_sel_restricted' defined but not used

Fix this by inlining the stub.

Fixes 8b6e88555971 ("regulator: rohm-regulator: add helper for restricted voltage setting")

---
I broke the build - sorry for that. This should probably go to Mark's tree even if it actually changes the headers under MFD :( Sorry for the trouble!

I think it might be even better to remove whole dummy fuction - but at this point when the build is already broken - it's safer to just inline and consider removing when there's the luxury of having the time to test it.

 include/linux/mfd/rohm-generic.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/linux/mfd/rohm-generic.h +2 -1
index 35c5866f48b7..080d60adcd5f 100644
@@ -90,7 +90,8 @@ static inline int rohm_regulator_set_dvs_levels(const struct rohm_dvs_config *dv
 {
 	return 0;
 }
-static int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev,
+
+static inline int rohm_regulator_set_voltage_sel_restricted(struct regulator_dev *rdev,
 						     unsigned int sel)
 {
 	return 0;
Signature · 14 lines
2.31.1


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
maintainer
#1 lore raw
Quoted 9 lines · Matti Vaittinen

The function rohm_regulator_set_voltage_sel_restricted() has a stub implementation. Linux-next testing spot following:

include/linux/mfd/rohm-generic.h:93:12: error:
'rohm_regulator_set_voltage_sel_restricted' defined but not used

Fix this by inlining the stub.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: rohm-generic: iniline stub function

      commit: cff6f593251cdf5398dc3c57f7032b8e9dcb633e

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark