Skip to contentSkip to conversation

Empty IN_FORMATS in sun4i-drm

DISCUSSION Simon Ser 1 participant 1 message Dec 14, 2021 1 message not in the archive Arm/Allwinner sunXi SoC support

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): Ybiu8jZEyRii44Dw@luna

Simon Ser

author
#1 lore raw
Quoted 3 lines · Emmanuel Gil Peyrot

This makes me think the kernel should populate IN_FORMATS with at least the same formats as the format list when supported, or stop advertising this property altogether.

Yup. This is a bug in the driver.

Quoted 2 lines

Other compositors (such as phoc) still run file, probably because they use the format list exclusively, without consideration for modifiers.

phoc is based on wlroots, which falls back to its modifier-less codepath when a driver is missing IN_FORMATS (or if it's empty). But it does support modifier-aware buffer allocation as well.

Quoted 2 lines

Besides fixing this driver, would it make sense to also make Weston ignore an empty IN_FORMATS and fall back to the format list?

I'd rather not, because this makes it more difficult to find buggy drivers.