Skip to contentSkip to conversation

--tui should not be silently ignored

bug report xaizek 2 participants 2 messages Jan 22, 2022 – Jan 23, 2022

lore
Share & tools
lore

xaizek

author
#0 lore raw

Hello,

(Mind that I'm not subscribed to the list.)

If slang isn't available during compilation time, there is a warning at build time. However, users won't see it and will scratch their heads when --tui has no effect as I did 5 years ago and just found out that it still behaves the same (yes, I didn't report it then).

Please print a warning that --tui is being ignored if perf was compiled without slang or even make it an error (e.g., don't define the option), but don't silently ignore the option. I had to use strace and then grep sources to understand why TUI doesn't work. Documentation might also need an update to mention that availability of --tui depends on whether slang was found during build.

Regards,
xaizek

#1 lore raw
Quoted 10 lines · xaizek

Hello,

(Mind that I'm not subscribed to the list.)

If slang isn't available during compilation time, there is a warning at build time. However, users won't see it and will scratch their heads when --tui has no effect as I did 5 years ago and just found out that it still behaves the same (yes, I didn't report it then).

Quoted 6 lines

Please print a warning that --tui is being ignored if perf was compiled without slang or even make it an error (e.g., don't define the option), but don't silently ignore the option. I had to use strace and then grep sources to understand why TUI doesn't work. Documentation might also need an update to mention that availability of --tui depends on whether slang was found during build.

Thanks for reporting this. The patch:
https://lore.kernel.org/lkml/[email protected]/
at least addresses the command line option part of the problem. Consider trying the patches and supplying a Tested-by :-)

Thanks,
Ian

Quoted 2 lines

Regards,
xaizek