Skip to contentSkip to conversation

sched: Make preempt_enable_no_resched() behave like preempt_enable() on PREEMPT_RT

PATCH In review Sebastian Andrzej Siewior 2 participants 3 messages Mar 1, 2022 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: Make preempt_enable_no_resched() behave like preempt_enable() on PREEMPT_RT

From: Thomas Gleixner <[email protected]>

Use the distinction that has been made earlier between preempt_enable_no_resched() and sched_preempt_enable_no_resched(). sched_preempt_enable_no_resched() is used within the scheduler where an immediate schedule() follows. preempt_enable_no_resched() is used outside of the scheduler and an immediate schedule() invocation may not follow for other reasons.

The lack of an immediate schedule() invocation matters on PREEMPT_RT where it will introduce latencies while the scheduler expects a context switch.

---
 include/linux/preempt.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
include/linux/preempt.h +5 -1
index b4381f255a5ca..582e43856a532 100644
@@ -210,7 +210,11 @@ do { \
 	preempt_count_dec(); \
 } while (0)
 
-#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
+#ifdef CONFIG_PREEMPT_RT
+# define preempt_enable_no_resched() preempt_enable()
+#else
+# define preempt_enable_no_resched() sched_preempt_enable_no_resched()
+#endif
 
 #define preemptible()	(preempt_count() == 0 && !irqs_disabled())
 
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 24 lines · Sebastian Andrzej Siewior

From: Thomas Gleixner <[email protected]>

Use the distinction that has been made earlier between preempt_enable_no_resched() and sched_preempt_enable_no_resched(). sched_preempt_enable_no_resched() is used within the scheduler where an immediate schedule() follows. preempt_enable_no_resched() is used outside of the scheduler and an immediate schedule() invocation may not follow for other reasons.

The lack of an immediate schedule() invocation matters on PREEMPT_RT where it will introduce latencies while the scheduler expects a context switch.

---
 include/linux/preempt.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
include/linux/preempt.h +0 -0
index b4381f255a5ca..582e43856a532 100644

include/linux/preempt.h do { \ · line 217

Quoted 9 lines
include/linux/preempt.h +5 -1
@@ -210,7 +210,11 @@ do { \
 	preempt_count_dec(); \
 } while (0)
 
-#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
+#ifdef CONFIG_PREEMPT_RT
+# define preempt_enable_no_resched() preempt_enable()
+#else
+# define preempt_enable_no_resched() sched_preempt_enable_no_resched()
+#endif

Ignoring !x86 for a moment:

arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
include/linux/preempt.h:#define sched_preempt_enable_no_resched() \
include/linux/preempt.h:#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
include/linux/preempt.h:#define preempt_enable_no_resched_notrace() \
include/linux/preempt.h:#define sched_preempt_enable_no_resched()       barrier()
include/linux/preempt.h:#define preempt_enable_no_resched()             barrier()
include/linux/preempt.h:#define preempt_enable_no_resched_notrace()     barrier()
include/linux/preempt.h:#undef sched_preempt_enable_no_resched
include/linux/preempt.h:#undef preempt_enable_no_resched
include/linux/preempt.h:#undef preempt_enable_no_resched_notrace
kernel/sched/core.c:            preempt_enable_no_resched();
kernel/sched/core.c:                    preempt_enable_no_resched();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:    sched_preempt_enable_no_resched();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:            preempt_enable_no_resched_notrace();
kernel/sched/core.c:            preempt_enable_no_resched_notrace();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:    sched_preempt_enable_no_resched();
kernel/signal.c:                preempt_enable_no_resched();
kernel/smpboot.c:                       preempt_enable_no_resched();
lib/smp_processor_id.c: preempt_enable_no_resched_notrace();

Surely we can audit that... At a glance the proposed patch does more harm than good. Only the kmmio case looks obviousl fail, but then IIRC kmmio had worse problems.

#2 lore raw
Quoted 27 lines · Peter Zijlstra

Ignoring !x86 for a moment:

arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
include/linux/preempt.h:#define sched_preempt_enable_no_resched() \
include/linux/preempt.h:#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
include/linux/preempt.h:#define preempt_enable_no_resched_notrace() \
include/linux/preempt.h:#define sched_preempt_enable_no_resched()       barrier()
include/linux/preempt.h:#define preempt_enable_no_resched()             barrier()
include/linux/preempt.h:#define preempt_enable_no_resched_notrace()     barrier()
include/linux/preempt.h:#undef sched_preempt_enable_no_resched
include/linux/preempt.h:#undef preempt_enable_no_resched
include/linux/preempt.h:#undef preempt_enable_no_resched_notrace
kernel/sched/core.c:            preempt_enable_no_resched();
kernel/sched/core.c:                    preempt_enable_no_resched();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:    sched_preempt_enable_no_resched();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:            preempt_enable_no_resched_notrace();
kernel/sched/core.c:            preempt_enable_no_resched_notrace();
kernel/sched/core.c:            sched_preempt_enable_no_resched();
kernel/sched/core.c:    sched_preempt_enable_no_resched();
kernel/signal.c:                preempt_enable_no_resched();
kernel/smpboot.c:                       preempt_enable_no_resched();
lib/smp_processor_id.c: preempt_enable_no_resched_notrace();
Quoted 3 lines

Surely we can audit that... At a glance the proposed patch does more harm than good. Only the kmmio case looks obviousl fail, but then IIRC kmmio had worse problems.

I was looking at the same before posting it. The majority of it disappeared over time after certain someone made it worthless for modules. So I'm dropping it then.
Does it make sense to keep sched_preempt_enable_no_resched() or should I move everything to preempt_enable_no_resched()?

Sebastian