Skip to contentSkip to conversation

Adding the QCBOR library to kvm-unit-tests

kvm-unit-tests Alexandru Elisei 4 participants 7 messages Mar 15, 2022 – Mar 16, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

I would also like to mention that the QCBOR library is also used in Trusted Firmware-M [5], which is licensed under BSD 3-Clause.

[1] https://www.arm.com/architecture/security-features/arm-confidential-compute-architecture
[2] https://datatracker.ietf.org/doc/html/rfc8949
[3] https://github.com/laurencelundblade/QCBOR
[4] https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
[5] https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/lib/ext/qcbor

Thanks,
Alex
_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

#1 lore raw
Quoted 22 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

Quoted 4 lines

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

IANAL, but I think it should be ok to add those files to the kvm-unit-tests. With regards to the "non-infringement" extension, it seems to be the one mentioned here: https://enterprise.dejacode.com/licenses/public/bsd-x11/ ... and on the "license condition" tab they mention that it is compatible with the GPL. On gnu.org, they list e.g. the https://www.gnu.org/licenses/license-list.html#X11License which also contains a "non-infringement" statement, so that should really be compatible.

Thomas

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

#2 lore raw

Hi,

Quoted 28 lines · Thomas Huth
Quoted 22 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

Quoted 4 lines

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

Quoted 8 lines

IANAL, but I think it should be ok to add those files to the kvm-unit-tests. With regards to the "non-infringement" extension, it seems to be the one mentioned here: https://enterprise.dejacode.com/licenses/public/bsd-x11/ ... and on the "license condition" tab they mention that it is compatible with the GPL. On gnu.org, they list e.g. the
https://www.gnu.org/licenses/license-list.html#X11License which also contains a "non-infringement" statement, so that should really be compatible.

Thanks you for the links, I wasn't aware of them. They further confirm that QCBOR is indeed compatible with GPLv2.

Thanks,
Alex

Quoted 3 lines

Thomas

#3 lore raw
In reply to Alexandru Elisei
Quoted 30 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

I would also like to mention that the QCBOR library is also used in Trusted Firmware-M [5], which is licensed under BSD 3-Clause.

Quoted 9 lines

[1] https://www.arm.com/architecture/security-features/arm-confidential-compute-architecture
[2] https://datatracker.ietf.org/doc/html/rfc8949
[3] https://github.com/laurencelundblade/QCBOR
[4] https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
[5] https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/lib/ext/qcbor

Thanks,
Alex

Assuming the license is OK (I'm not educated in that stuff enough to give an opinion), then the next question is how do we want to integrate it? Bring it all in, like we did libfdt? Or use a git submodule?

Thanks,
drew

#4 lore raw

Hi,

Quoted 37 lines · Andrew Jones
Quoted 36 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

I would also like to mention that the QCBOR library is also used in Trusted Firmware-M [5], which is licensed under BSD 3-Clause.

[1] https://www.arm.com/architecture/security-features/arm-confidential-compute-architecture
[2] https://datatracker.ietf.org/doc/html/rfc8949
[3] https://github.com/laurencelundblade/QCBOR
[4] https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
[5] https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/lib/ext/qcbor

Quoted 7 lines
Quoted 3 lines

Thanks,
Alex

Assuming the license is OK (I'm not educated in that stuff enough to give an opinion), then the next question is how do we want to integrate it? Bring it all in, like we did libfdt? Or use a git submodule?

This is still a work in progress and at this time I'm not sure how it will end up looking. Do you have a preference for one or the other?

Thanks,
Alex

#5 lore raw

Hi Andrew, Alexandru,

Quoted 47 lines · Alexandru Elisei

Hi,

Quoted 44 lines · Andrew Jones
Quoted 30 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

I would also like to mention that the QCBOR library is also used in Trusted Firmware-M [5], which is licensed under BSD 3-Clause.

Quoted 9 lines

[1] https://www.arm.com/architecture/security-features/arm-confidential-compute-architecture
[2] https://datatracker.ietf.org/doc/html/rfc8949
[3] https://github.com/laurencelundblade/QCBOR
[4] https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
[5] https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/lib/ext/qcbor

Thanks,
Alex

Assuming the license is OK (I'm not educated in that stuff enough to give an opinion), then the next question is how do we want to integrate it? Bring it all in, like we did libfdt? Or use a git submodule?

Thanks for your feedback.

Quoted 4 lines

This is still a work in progress and at this time I'm not sure how it will end up looking. Do you have a preference for one or the other?

My two cents. With the submodule approach, we can move to the later versions of the QCBOR library (if needed, in the future) without much noise in the history.

Cheers
Suzuki

Quoted 2 lines

Thanks,
Alex

#6 lore raw
In reply to Alexandru Elisei
Quoted 44 lines · Alexandru Elisei

Hi,

Quoted 41 lines · Andrew Jones
Quoted 39 lines · Alexandru Elisei

Hi,

Arm is planning to upstream tests that are being developed as part of the Confidential Compute Architecture [1]. Some of the tests target the attestation part of creating and managing a confidential compute VM, which requires the manipulation of messages in the Concise Binary Object Representation (CBOR) format [2].

I would like to ask if it would be acceptable from a license perspective to include the QCBOR library [3] into kvm-unit-tests, which will be used for encoding and decoding of CBOR messages.

The library is licensed under the 3-Clause BSD license, which is compatible with GPLv2 [4]. Some of the files that were created inside Qualcomm before the library was open-sourced have a slightly modified 3-Clause BSD license, where a NON-INFRINGMENT clause is added to the disclaimer:

"THIS SOFTWARE IS PROVIDED "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE **AND NON-INFRINGEMENT** ARE DISCLAIMED" (emphasis by me on the added clause).

The files in question include the core files that implement the encode/decode functionality, and thus would have to be included in kvm-unit-tests. I believe that the above modification does not affect the compatibility with GPLv2.

I would also like to mention that the QCBOR library is also used in Trusted Firmware-M [5], which is licensed under BSD 3-Clause.

[1] https://www.arm.com/architecture/security-features/arm-confidential-compute-architecture
[2] https://datatracker.ietf.org/doc/html/rfc8949
[3] https://github.com/laurencelundblade/QCBOR
[4] https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses
[5] https://git.trustedfirmware.org/TF-M/trusted-firmware-m.git/tree/lib/ext/qcbor

Thanks,
Alex

Quoted 7 lines
Quoted 3 lines

Assuming the license is OK (I'm not educated in that stuff enough to give an opinion), then the next question is how do we want to integrate it? Bring it all in, like we did libfdt? Or use a git submodule?

This is still a work in progress and at this time I'm not sure how it will end up looking. Do you have a preference for one or the other?

I think I prefer a submodule, but I'm all ears on this. By coincidence the same topic is now also being discussed here

https://lore.kernel.org/kvm/[email protected]/T/#mb5db3e9143e4f2ca47d24a32b30e7b2f014934e8

Thanks,
drew