Skip to contentSkip to conversation

Rare page cache data corruption fix

GIT PULL Merged Matthew Wilcox 4 participants 4 messages Apr 22, 2022 – Apr 30, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Syzbot found a nasty race between large page splitting and page lookup. Details in the commit log, but fortunately it has a reliable reproducer. I thought it better to send this one to you straight away.

The other commit fixes the test suite build, again.

The following changes since commit 281b9d9a4b02229b602a14f7540206b0fbe4134f:

Merge branch 'akpm' (patches from Andrew) (2022-04-22 10:10:43 -0700)

are available in the Git repository at:

git://git.infradead.org/users/willy/xarray.git tags/xarray-5.18a

for you to fetch changes up to 63b1898fffcd8bd81905b95104ecc52b45a97e21:

XArray: Disallow sibling entries of nodes (2022-04-22 15:35:40 -0400)

----------------------------------------------------------------
XArray: Two fixes for 5.18

- Fix the test suite build for kmem_cache_alloc_lru()

- Fix a rare race between split and load

----------------------------------------------------------------
Matthew Wilcox (Oracle) (2):
tools: Add kmem_cache_alloc_lru()
XArray: Disallow sibling entries of nodes

 lib/xarray.c                     | 2 ++
 tools/include/linux/slab.h       | 8 +++++++-
 tools/testing/radix-tree/linux.c | 3 ++-
 3 files changed, 11 insertions(+), 2 deletions(-)
#1 lore raw
Quoted 3 lines · Matthew Wilcox

Syzbot found a nasty race between large page splitting and page lookup. Details in the commit log, but fortunately it has a reliable reproducer.

The commit message does mention it ("I have not added a new test for this bug."), but I'll echo it anyway, since you say it can be reliably reproduced - getting that repro into the testsuite would be lovely.

Linus

merge bot Merged
#2 lore raw
In reply to Matthew Wilcox
The pull request you sent on Fri, 22 Apr 2022 20:45:35 +0100:

The pull request you sent on Fri, 22 Apr 2022 20:45:35 +0100:

Quoted 1 line

git://git.infradead.org/users/willy/xarray.git tags/xarray-5.18a

has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/22f19f67404833c2282b7a8c2f4703d9aff8f748

Thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/prtracker.html
maintainer
#3 lore raw
In reply to Matthew Wilcox
Quoted 5 lines · On Fri, 22 Apr 2022 20:45:35 +0100 Matthew Wilcox <[email protected]> wrote:

XArray: Two fixes for 5.18

- Fix the test suite build for kmem_cache_alloc_lru()

- Fix a rare race between split and load

This commit did not have a cc:stable. It has a Fixes:, but we've asked Greg not to backport patches which weren't explicitly cc:stable.

If you think this should be backported I suggest you let Greg know.