drm/sun4i: dsi: delete unnecessary IS_ERR() checks
Subsystems (5)
PATCH 1/1 drm/sun4i: dsi: delete unnecessary IS_ERR() checks
The "dsi->bus_clk" pointer cannot be an error pointer at this point. The check is confusing and unnecessary. Delete it.
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +3 -4
@@ -1193,8 +1193,8 @@ static int sun6i_dsi_probe(struct platform_device *pdev) err_unprotect_clk:clk_rate_exclusive_put (dsi->mod_clk); err_attach_clk: -if (!IS_ERR (dsi->bus_clk)) -regmap_mmio_detach_clk (dsi->regs); +regmap_mmio_detach_clk (dsi->regs); +return ret; }
@@ -1207,8 +1207,7 @@ static int sun6i_dsi_remove(struct platform_device *pdev)mipi_dsi_host_unregister (&dsi->host);clk_rate_exclusive_put (dsi->mod_clk); -if (!IS_ERR (dsi->bus_clk)) -regmap_mmio_detach_clk (dsi->regs); +regmap_mmio_detach_clk (dsi->regs);return 0 ; }
Signature · 1 line
2.35.1
Maxime Ripard
AppliedRe: (subset) [PATCH] drm/sun4i: dsi: delete unnecessary IS_ERR() checks
Quoted 4 lines · Dan Carpenter
The "
dsi->bus_clk" pointer cannot be an error pointer at this point. The check is confusing and unnecessary. Delete it.
Applied to drm/drm-misc (drm-misc-next).
Thanks!
Maxime