drm/msm: return an error pointer in msm_gem_prime_get_sg_table()
Subsystems (4)
PATCH 1/1 drm/msm: return an error pointer in msm_gem_prime_get_sg_table()
The msm_gem_prime_get_sg_table() needs to return error pointers on error. This is called from drm_gem_map_dma_buf() and returning a NULL will lead to a crash in that function.
Fixes ac45146733b0 ("drm/msm: fix msm_gem_prime_get_sg_table()")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/gpu/drm/msm/msm_gem_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/msm_gem_prime.c +1 -1
@@ -17,7 +17,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)int npages = obj->size >>PAGE_SHIFT ;if (WARN_ON (!msm_obj->pages))/* should have already pinned! */ -return NULL ; +return ERR_PTR (-ENOMEM );return drm_prime_pages_to_sg (obj->dev, msm_obj->pages, npages); }
Signature · 1 line
2.35.1
Quoted 6 lines · Dan Carpenter
The
msm_gem_prime_get_sg_table()needs to return error pointers on error. This is called fromdrm_gem_map_dma_buf()and returning a NULL will lead to a crash in that function.Fixes ac45146733b0 ("drm/msm: fix msm_gem_prime_get_sg_table()")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Dmitry Baryshkov <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/msm/msm_gem_prime.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/msm/msm_gem_prime.c +1
-1@@ -17,7 +17,7 @@ struct sg_table *msm_gem_prime_get_sg_table(struct drm_gem_object *obj)int npages = obj->size >>PAGE_SHIFT ;if (WARN_ON (!msm_obj->pages))/* should have already pinned! */ -return NULL ; +return ERR_PTR (-ENOMEM );return drm_prime_pages_to_sg (obj->dev, msm_obj->pages, npages); }
Signature · 2 lines
With best wishes Dmitry