Skip to contentSkip to conversation

mm/shmem: Fix uninitialized variable bug

PATCH New Dan Carpenter 1 participant 1 message May 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/shmem: Fix uninitialized variable bug

The "folio" pointer is not initialized on some of the early error paths.

Fixes 2b58b3f33ba2 ("mm/shmem: convert shmem_swapin_page() to shmem_swapin_folio()")

---
This goes through Andrew's tree and will presumably be folded in with the original patch.

 mm/shmem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/shmem.c +1 -1
index 107f1e4dd0aa..97f9ea59a7d1 100644
@@ -1681,8 +1681,8 @@ static int shmem_swapin_folio(struct inode *inode, pgoff_t index,
 	struct address_space *mapping = inode->i_mapping;
 	struct shmem_inode_info *info = SHMEM_I(inode);
 	struct mm_struct *charge_mm = vma ? vma->vm_mm : NULL;
+	struct folio *folio = NULL;
 	struct page *page;
-	struct folio *folio;
 	swp_entry_t swap;
 	int error;
 
Signature · 1 line
2.35.1