Skip to contentSkip to conversation

xfs/545: check for fallocate support before running test

PATCH In review Darrick J. Wong 3 participants 3 messages May 24, 2022 – May 27, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/545: check for fallocate support before running test

From: Darrick J. Wong <[email protected]>

This test fails when alwayscow mode is enabled:

545.out.bad renamed from 545.out +1 -0
@@ -1,4 +1,5 @@
 QA output created by 545
+fallocate: Operation not supported
 Creating directory system to dump using fsstress.
 

Fix this by checking for fallocate support first.

---
 tests/xfs/545 |    1 +
 1 file changed, 1 insertion(+)
tests/xfs/545 +1 -0
index e3dd300a..dfe2f2dc 100755
@@ -14,6 +14,7 @@ _begin_fstest auto quick dump
 . ./common/dump
 
 _supported_fs xfs
+_require_xfs_io_command "falloc"
 _require_scratch
 
 # A large stripe unit will put the root inode out quite far
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

This test fails when alwayscow mode is enabled:

545.out.bad renamed from 545.out +1 -0
@@ -1,4 +1,5 @@
 QA output created by 545
+fallocate: Operation not supported
 Creating directory system to dump using fsstress.
 

Fix this by checking for fallocate support first.

Quoted 1 line

Looks good.

Signature · 2 lines
Dave Chinner
[email protected]