Skip to contentSkip to conversation

parisc: Prevent using same register as soure and target in extru/shr

PATCH In review Helge Deller 3 participants 5 messages May 17, 2022 – May 18, 2022 PA-RISC architecture

lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/1 parisc: Prevent using same register as soure and target in extru/shr

In 2004 Randolph added the shr() assembly macro and noted that the source and target register could not be the same.

I did not find any confindence in the docs for this restriction. Maybe it's related that on PA2.0 the upper bits may be clobbered?

Anyway, add a compile-time check for it now.

arch/parisc/include/asm/assembly.h +3 -0
index ea0cb318b13d..ca1a12ae5ee7 100644
@@ -146,6 +146,9 @@
 	/* Shift Right - note the r and t can NOT be the same! */
 	.macro shr r, sa, t
 	extru \r, 31-(\sa), 32-(\sa), \t
+.ifc \r,\t
+        .error "Can not used the same register (\r) in shr/extru as source and target register."
+.endif
 	.endm
 
 	/* pa20w version of shift right */
author maintainer
#1 lore raw
Quoted 5 lines · Helge Deller

In 2004 Randolph added the shr() assembly macro and noted that the source and target register could not be the same.

I did not find any confindence in the docs for this restriction. Maybe it's related that on PA2.0 the upper bits may be clobbered?

Looking at the generated kernel code from C-files, I'll find all over usages of
extru source, x,y, target
where source and target are the same register.
So, at least for 32-bit this restriction can't be true.

Any ideas why this restriction could have been added to the comments?

Helge

Quoted 18 lines

Anyway, add a compile-time check for it now.

arch/parisc/include/asm/assembly.h +3 -0
index ea0cb318b13d..ca1a12ae5ee7 100644
@@ -146,6 +146,9 @@
 	/* Shift Right - note the r and t can NOT be the same! */
 	.macro shr r, sa, t
 	extru \r, 31-(\sa), 32-(\sa), \t
+.ifc \r,\t
+        .error "Can not used the same register (\r) in shr/extru as source and target register."
+.endif
 	.endm
 
 	/* pa20w version of shift right */
#2 lore raw

I'm not aware of any PA-RISC instructions where the source and target registers can't be the same.

In gcc asm statements, there are early clobber situations where the source and target can't be the same. The same situation could occur in assembler macros but never when there's a single instruction.

The only thing unusual about the extru instruction is the most significant 32 bits in the target are undefined on PA 2.0.  Thus, its use needs to be limited to 32-bit extracts.

Dave

Quoted 34 lines · Helge Deller
Quoted 5 lines · Helge Deller

In 2004 Randolph added the shr() assembly macro and noted that the source and target register could not be the same.

I did not find any confindence in the docs for this restriction. Maybe it's related that on PA2.0 the upper bits may be clobbered?

Looking at the generated kernel code from C-files, I'll find all over usages of
extru source, x,y, target
where source and target are the same register.
So, at least for 32-bit this restriction can't be true.

Any ideas why this restriction could have been added to the comments?

Helge

Quoted 18 lines

Anyway, add a compile-time check for it now.

arch/parisc/include/asm/assembly.h +3 -0
index ea0cb318b13d..ca1a12ae5ee7 100644
@@ -146,6 +146,9 @@
  	/* Shift Right - note the r and t can NOT be the same! */
  	.macro shr r, sa, t
  	extru \r, 31-(\sa), 32-(\sa), \t
+.ifc \r,\t
+        .error "Can not used the same register (\r) in shr/extru as source and target register."
+.endif
  	.endm
 
  	/* pa20w version of shift right */
Signature · 1 line
John David Anglin  [email protected]
#3 lore raw
In reply to Helge Deller
Quoted 11 lines · Helge Deller
Quoted 5 lines · Helge Deller

In 2004 Randolph added the shr() assembly macro and noted that the source and target register could not be the same.

I did not find any confindence in the docs for this restriction. Maybe it's related that on PA2.0 the upper bits may be clobbered?

Looking at the generated kernel code from C-files, I'll find all over usages of
extru source, x,y, target
where source and target are the same register.
So, at least for 32-bit this restriction can't be true.

I did a quick objdump on the 64 bit HP-UX kernel and that one also uses extrd/extrw where target and source are the same register. So i don't think that restriction is true.

author maintainer
#4 lore raw
Quoted 9 lines · Sven Schnelle
Quoted 7 lines · Helge Deller
Quoted 5 lines · Helge Deller

In 2004 Randolph added the shr() assembly macro and noted that the source and target register could not be the same.

I did not find any confindence in the docs for this restriction. Maybe it's related that on PA2.0 the upper bits may be clobbered?

Quoted 8 lines
Quoted 4 lines

Looking at the generated kernel code from C-files, I'll find all over usages of
extru source, x,y, target
where source and target are the same register.
So, at least for 32-bit this restriction can't be true.

I did a quick objdump on the 64 bit HP-UX kernel and that one also uses extrd/extrw where target and source are the same register. So i don't think that restriction is true.

Thanks for checking!
Maybe it's meant that it clobbers when running *32-bit* code on PA2.0? Just a thought...

Helge