Skip to contentSkip to conversation

rtc: rzn1: Fix error code in probe

PATCH Applied Dan Carpenter 3 participants 4 messages May 19, 2022 – May 24, 2022

Subsystems (3)
Kernel janitors Real time clock (RTC) Renesas RZ/N1 RTC controller driver
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 rtc: rzn1: Fix error code in probe

There is a copy and paste error so this code returns the wrong variable.

Fixes deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/rtc/rtc-rzn1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-rzn1.c +1 -1
index 0b4bf6e43464..ff49cedd98b8 100644
@@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
 
 	rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc->rtcdev))
-		return PTR_ERR(rtc);
+		return PTR_ERR(rtc->rtcdev);
 
 	rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000;
 	rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099;
Signature · 1 line
2.35.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Dan,

[email protected] wrote on Thu, 19 May 2022 16:56:19 +0300:

Quoted 3 lines

There is a copy and paste error so this code returns the wrong variable.

Fixes deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")

The Fixes here will point to an unknown id once pulled by Linus.

Otherwise

Reviewed-by Miquel Raynal <[email protected]>
Quoted 10 lines
Signed-off-by Dan Carpenter <[email protected]>
---
 drivers/rtc/rtc-rzn1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-rzn1.c +0 -0
index 0b4bf6e43464..ff49cedd98b8 100644

drivers/rtc/rtc-rzn1.c static int rzn1_rtc_probe(struct platform_device *pdev) · line 354

Quoted 8 lines
drivers/rtc/rtc-rzn1.c +1 -1
@@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
 
 	rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev);
 	if (IS_ERR(rtc->rtcdev))
-		return PTR_ERR(rtc);
+		return PTR_ERR(rtc->rtcdev);
 
 	rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000;
 	rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099;

Thanks,
Miquèl

author
#2 lore raw
Quoted 9 lines · Miquel Raynal

Hi Dan,

[email protected] wrote on Thu, 19 May 2022 16:56:19 +0300:

Quoted 3 lines

There is a copy and paste error so this code returns the wrong variable.

Fixes deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")

The Fixes here will point to an unknown id once pulled by Linus.

No, it shouldn't be an issue.

I'm assuming based on the S-o-b tags that this goes through Alexandre's tree. The hash will stay the same unless Alexandre rebases.

When a maintainer rebases then it's their responsibility to update the Fixes tags. Most likely the maintainer just going to fold the fixes patches into the original patch so it's a moot issue. There are automated checks run on linux-next for incorrect Fixes tags so, you know, don't rebase and then push immediately; first let the autobuilders check for stuff like this.

regards,
dan carpenter

maintainer Applied
#3 lore raw
In reply to Dan Carpenter
Quoted 3 lines · Dan Carpenter

There is a copy and paste error so this code returns the wrong variable.

Applied, thanks!

[1/1] rtc: rzn1: Fix error code in probe

      commit: 0b6da785130d9e8cf33d001a7bf08a979c87d019

Best regards,

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com