Skip to contentSkip to conversation

scsi: ufs: ufshcd: delete unnecessary NULL check

PATCH Applied Dan Carpenter 2 participants 3 messages May 23, 2022 – May 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: ufshcd: delete unnecessary NULL check

The "info" pointer points to somewhere in the middle of the "hba" struct. It can't possibly be NULL. Delete the NULL check.

---
 drivers/ufs/core/ufshcd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/ufs/core/ufshcd.c +1 -4
index efe67a381c32..01fb4bad86be 100644
@@ -8445,10 +8445,7 @@ static int ufshcd_init_hba_vreg(struct ufs_hba *hba)
 {
 	struct ufs_vreg_info *info = &hba->vreg_info;
 
-	if (info)
-		return ufshcd_get_vreg(hba->dev, info->vdd_hba);
-
-	return 0;
+	return ufshcd_get_vreg(hba->dev, info->vdd_hba);
 }
 
 static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on)
Signature · 1 line
2.35.1
#1 lore raw

Dan,

Quoted 2 lines

The "info" pointer points to somewhere in the middle of the "hba" struct. It can't possibly be NULL. Delete the NULL check.

Applied to 5.19/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering