fbcon: Fix accelerated fbdev scrolling while logo is still shown
Subsystems (3)
Helge Deller
maintainerPATCH 1/1 fbcon: Fix accelerated fbdev scrolling while logo is still shown
There is no need to directly skip over to the SCROLL_REDRAW case while the logo is still shown.
When using DRM, this change has no effect because the code will reach the SCROLL_REDRAW case immediately anyway.
But if you run an accelerated fbdev driver and have FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATION enabled, console scrolling is slowed down by factors so that it feels as if you use a 9600 baud terminal.
So, drop those unnecessary checks and speed up fbdev console acceleration during bootup.
drivers/video/fbdev/core/fbcon.c +0 -4
@@ -1706,8 +1706,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,case SM_UP :if (count > vc->vc_rows)/* Maximum realistic size */ count = vc->vc_rows; -if (logo_shown >=0 ) - goto redraw_up;switch (fb_scrollmode (p)) {case SCROLL_MOVE : fbcon_redraw_blit(vc, info, p, t, b - t - count,
@@ -1796,8 +1794,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,case SM_DOWN :if (count > vc->vc_rows)/* Maximum realistic size */ count = vc->vc_rows; -if (logo_shown >=0 ) - goto redraw_down;switch (fb_scrollmode (p)) {case SCROLL_MOVE : fbcon_redraw_blit(vc, info, p, b - 1, b - t - count,
Quoted 11 lines · Helge Deller
There is no need to directly skip over to the
SCROLL_REDRAWcase while the logo is still shown.When using DRM, this change has no effect because the code will reach the
SCROLL_REDRAWcase immediately anyway.But if you run an accelerated fbdev driver and have
FRAMEBUFFER_CONSOLE_LEGACY_ACCELERATIONenabled, console scrolling is slowed down by factors so that it feels as if you use a 9600 baud terminal.
Quoted 5 lines
So, drop those unnecessary checks and speed up fbdev console acceleration during bootup.
Signed-off-by Helge Deller <[email protected]>
I'm not entirely sure this is 100% perfect, but I don't think it'll make anything worse, so
I'm assuming you'll push this to drm-misc-fixes? I pinged drm-misc maintainers to make sure that tree is forwarded to -rc1. -Daniel
Quoted 23 lines
drivers/video/fbdev/core/fbcon.c +0
-4@@ -1706,8 +1706,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,case SM_UP :if (count > vc->vc_rows)/* Maximum realistic size */ count = vc->vc_rows; -if (logo_shown >=0 ) - goto redraw_up;switch (fb_scrollmode (p)) {case SCROLL_MOVE : fbcon_redraw_blit(vc, info, p, t, b - t - count,@@ -1796,8 +1794,6 @@ static bool fbcon_scroll(struct vc_data *vc, unsigned int t, unsigned int b,case SM_DOWN :if (count > vc->vc_rows)/* Maximum realistic size */ count = vc->vc_rows; -if (logo_shown >=0 ) - goto redraw_down;switch (fb_scrollmode (p)) {case SCROLL_MOVE : fbcon_redraw_blit(vc, info, p, b - 1, b - t - count,
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch