drm: logicvc: Fix uninitialized variable in probe
PATCH 1/1 drm: logicvc: Fix uninitialized variable in probe
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
--- drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/logicvc/logicvc_drm.c +1 -1
@@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev)struct logicvc_drm *logicvc;struct device *dev = &pdev->dev;struct drm_device *drm_dev; -struct regmap *regmap; +struct regmap *regmap =NULL ;struct resource res;void __iomem *base;int irq;
Signature · 1 line
2.35.1
Hi Dan,
Quoted 5 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>
Nice catch, thanks a lot!
Cheers,
Paul
Quoted 20 lines
--- drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/logicvc/logicvc_drm.c +1
-1@@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev)struct logicvc_drm *logicvc;struct device *dev = &pdev->dev;struct drm_device *drm_dev; -struct regmap *regmap; +struct regmap *regmap =NULL ;struct resource res;void __iomem *base;int irq;Signature · 1 line
2.35.1
Signature · 3 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Hi,
Quoted 10 lines · Paul Kocialkowski
Quoted 5 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>Nice catch, thanks a lot!
Since you have the commit rights to drm-misc, you should apply it
Maxime
Hi,
Quoted 7 lines · Maxime Ripard
Hi,
Quoted 4 lines · Paul Kocialkowski
Quoted 3 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>Nice catch, thanks a lot!
Since you have the commit rights to drm-misc, you should apply it
Absolutely, I'm on my way to doing that.
Do I need to reply to the emails with a message indicating that I merged them or is using the tool sufficient?
Thanks,
Paul
Signature · 3 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Quoted 13 lines · Paul Kocialkowski
Hi,
Quoted 10 lines · Maxime Ripard
Hi,
Quoted 7 lines · Paul Kocialkowski
Quoted 5 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Nice catch, thanks a lot!
Since you have the commit rights to drm-misc, you should apply it
Absolutely, I'm on my way to doing that.
Giving your Acked-by is confusing then, because it's kind of implied if you apply it.
Quoted 2 lines
Do I need to reply to the emails with a message indicating that I merged them or is using the tool sufficient?
Sending an email is better, dim doesn't do that
Maxime
Paul Kocialkowski
AppliedHi,
Quoted 6 lines · Paul Kocialkowski
Hi Dan,
Quoted 3 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Quoted 6 lines
Quoted 2 lines
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>Nice catch, thanks a lot!
Pushed to drm-misc-next, thanks!
Paul
Quoted 29 lines
Cheers,
Paul
Quoted 20 lines
--- drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/logicvc/logicvc_drm.c +1
-1@@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev)struct logicvc_drm *logicvc;struct device *dev = &pdev->dev;struct drm_device *drm_dev; -struct regmap *regmap; +struct regmap *regmap =NULL ;struct resource res;void __iomem *base;int irq;Signature · 1 line
2.35.1Signature · 3 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Signature · 3 lines
Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com
Quoted 15 lines · Paul Kocialkowski
Hi,
Quoted 12 lines · Maxime Ripard
Hi,
Quoted 9 lines · Paul Kocialkowski
Quoted 5 lines · Dan Carpenter
The "regmap" is supposed to be initialized to NULL but it's used without being initialized.
Fixes efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")Signed-off-by Dan Carpenter <[email protected]>Nice catch, thanks a lot!
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Since you have the commit rights to drm-misc, you should apply it
Absolutely, I'm on my way to doing that.
Do I need to reply to the emails with a message indicating that I merged them or is using the tool sufficient?
Going back on this, but it's fairly easy with b4 to generate the messages that you applied them.
For example, I'm using:
cat mail | b4 am -t --no-cover -o - -P _ | dim apply-branch drm-misc-fixes
b4 am will retrieve the last version of the patch from lore (and only the current patch with --no-cover -P _), add the tags (-t) and output it on stdout (-o -) and pass it to dim apply-branch
Then, you can do
b4 ty -a && git send-email *.thanks && rm *.thanks
And it will send a mail for every patch you applied in the current branch
Maxime