mt76: mt7915: fix an uninitialized variable bug

PATCH New Dan Carpenter 1 participant 1 message Jul 22, 2022

Subsystems (3)

Kernel janitors Arm MediaTek MediaTek MT76 wireless LAN driver

lore

Share & tools

lore

Dan Carpenter

author

2022-07-22 06:35 UTC #0 lore raw

PATCH 1/1 mt76: mt7915: fix an uninitialized variable bug

Smatch complains that:

drivers/net/wireless/mediatek/mt76/mt7915/mac.c:428 mt7915_mac_fill_rx()
error: uninitialized symbol 'msta'.

It looks like this was supposed to be initialized to NULL.

Fixes 0880d40871d1 ("mt76: connac: move mt76_connac2_reverse_frag0_hdr_trans in mt76-connac module")

Signed-off-by Dan Carpenter <[email protected]>

---
 drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/wireless/mediatek/mt76/mt7915/mac.c +1 -1

index 60ae834d95a6..4ddcd3afa428 100644
@@ -232,7 +232,7 @@ mt7915_mac_fill_rx(struct mt7915_dev *dev, struct sk_buff *skb)
 	bool unicast, insert_ccmp_hdr = false;
 	u8 remove_pad, amsdu_info;
 	u8 mode = 0, qos_ctl = 0;
-	struct mt7915_sta *msta;
+	struct mt7915_sta *msta = NULL;
 	bool hdr_trans;
 	u16 hdr_gap;
 	u16 seq_ctrl = 0;

Signature · 1 line

2.35.1