cxl/region: Fix IS_ERR() vs NULL check
Subsystems (2)
PATCH 1/1 cxl/region: Fix IS_ERR() vs NULL check
The nvdimm_pmem_region_create() function returns NULL on error. It does not return error pointers.
Fixes 04ad63f086d1 ("cxl/region: Introduce cxl_pmem_region objects")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/cxl/pmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/cxl/pmem.c +2 -2
@@ -525,8 +525,8 @@ static int cxl_pmem_region_probe(struct device *dev) cxlr_pmem->nd_region =nvdimm_pmem_region_create (cxl_nvb->nvdimm_bus, &ndr_desc); -if (IS_ERR (cxlr_pmem->nd_region)) { - rc =PTR_ERR (cxlr_pmem->nd_region); +if (!cxlr_pmem->nd_region) { + rc = -ENOMEM ; goto err; }
Signature · 1 line
2.35.1
Quoted 5 lines · On Wed, 3 Aug 2022 12:07:50 +0300 Dan Carpenter <[email protected]>…
The
nvdimm_pmem_region_create()function returns NULL on error. It does not return error pointers.Fixes 04ad63f086d1 ("cxl/region: Introduce cxl_pmem_region objects")Signed-off-by Dan Carpenter <[email protected]>
LGTM
Reviewed-by Jonathan Cameron <[email protected]>
Quoted 19 lines
--- drivers/cxl/pmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/cxl/pmem.c +2
-2@@ -525,8 +525,8 @@ static int cxl_pmem_region_probe(struct device *dev) cxlr_pmem->nd_region =nvdimm_pmem_region_create (cxl_nvb->nvdimm_bus, &ndr_desc); -if (IS_ERR (cxlr_pmem->nd_region)) { - rc =PTR_ERR (cxlr_pmem->nd_region); +if (!cxlr_pmem->nd_region) { + rc = -ENOMEM ; goto err; }
Dan Williams
AppliedQuoted 14 lines · Dan Carpenter
The
nvdimm_pmem_region_create()function returns NULL on error. It does not return error pointers.Fixes 04ad63f086d1 ("cxl/region: Introduce cxl_pmem_region objects")Signed-off-by Dan Carpenter <[email protected]>--- drivers/cxl/pmem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/cxl/pmem.c +0
-0
drivers/cxl/pmem.c static int cxl_pmem_region_probe(struct device *dev) · line 529
Quoted 7 lines
drivers/cxl/pmem.c +2
-2@@ -525,8 +525,8 @@ static int cxl_pmem_region_probe(struct device *dev) cxlr_pmem->nd_region =nvdimm_pmem_region_create (cxl_nvb->nvdimm_bus, &ndr_desc); -if (IS_ERR (cxlr_pmem->nd_region)) { - rc =PTR_ERR (cxlr_pmem->nd_region); +if (!cxlr_pmem->nd_region) { + rc = -ENOMEM ;
Thanks, applied.