target/hppa: Fix proberi instruction emulation for linux-user
PATCH 1/1 target/hppa: Fix proberi instruction emulation for linux-user
The proberi assembler instruction checks the read/write access rights for the page of a given address and shall return a value of 1 if the test succeeds and a value of 0 on failure in the target register.
But when run in linux-user mode, qemu currently simply returns the return code of page_check_range() which returns 0 on success and -1 on failure, which is the opposite of what proberi should return.
Fix it by checking the return code of page_check_range() and return the expected return value.
The easiest way to reproduce the issue is by running "/lib/ld.so.1 --version" in a chroot which fails without this patch. At startup of ld.so the __canonicalize_funcptr_for_compare() function is used to resolve the function address out of a function descriptor, which fails because proberi (due to the wrong return code) seems to indicate that the given address isn't accessible.
target/hppa/op_helper.c +1 -1
@@ -170,7 +170,7 @@ target_ureg HELPER(probe)(CPUHPPAState *env, target_ulong addr, uint32_t level, uint32_t want) {#ifdef CONFIG_USER_ONLY -return page_check_range (addr,1 , want); +return (page_check_range (addr,1 , want) ==0 ) ?1 :0 ;#else int prot, excp;hwaddr phys;