Skip to contentSkip to conversation

net: ngbe: Add build support for ngbe

bug report Dan Carpenter 1 participant 1 message Sep 1, 2022 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hello Mengyuan Lou,

The patch e79e40c83b9f: "net: ngbe: Add build support for ngbe" from Aug 26, 2022, leads to the following Smatch static checker warning:

drivers/net/ethernet/wangxun/ngbe/ngbe_main.c:54 ngbe_shutdown()
error: uninitialized symbol 'wake'.

drivers/net/ethernet/wangxun/ngbe/ngbe_main.c

    47 static void ngbe_shutdown(struct pci_dev *pdev)
    48 {
    49         bool wake;
    50 
    51         ngbe_dev_shutdown(pdev, &wake);
                                       ^^^^^

Never initialized.

    52 
    53         if (system_state == SYSTEM_POWER_OFF) {
--> 54                 pci_wake_from_d3(pdev, wake);
                                              ^^^^

Uninitalized.

    55                 pci_set_power_state(pdev, PCI_D3hot);
    56         }
    57 }

regards,
dan carpenter