Skip to contentSkip to conversation

media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()

PATCH In review Dan Carpenter 3 participants 3 messages Sep 1, 2022 – Sep 5, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: platform: mtk-mdp3: fix error code in mdp_vpu_dev_init()

Return a negative error code if mdp_vpu_shared_mem_alloc() fails.

Fixes 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
---
 drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c +2 -1
index 9f5844385c8f..a72bed927bb6 100644
@@ -173,7 +173,8 @@ int mdp_vpu_dev_init(struct mdp_vpu_dev *vpu, struct mtk_scp *scp,
 	/* vpu work_size was set in mdp_vpu_ipi_handle_init_ack */
 
 	mem_size = vpu_alloc_size;
-	if (mdp_vpu_shared_mem_alloc(vpu)) {
+	err = mdp_vpu_shared_mem_alloc(vpu);
+	if (err) {
 		dev_err(&mdp->pdev->dev, "VPU memory alloc fail!");
 		goto err_mem_alloc;
 	}
Signature · 1 line
2.35.1
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

Return a negative error code if mdp_vpu_shared_mem_alloc() fails.

Fixes 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Quoted 18 lines
---
  drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/platform/mediatek/mdp3/mtk-mdp3-vpu.c +2 -1
index 9f5844385c8f..a72bed927bb6 100644
@@ -173,7 +173,8 @@ int mdp_vpu_dev_init(struct mdp_vpu_dev *vpu, struct mtk_scp *scp,
  	/* vpu work_size was set in mdp_vpu_ipi_handle_init_ack */
 
  	mem_size = vpu_alloc_size;
-	if (mdp_vpu_shared_mem_alloc(vpu)) {
+	err = mdp_vpu_shared_mem_alloc(vpu);
+	if (err) {
  		dev_err(&mdp->pdev->dev, "VPU memory alloc fail!");
  		goto err_mem_alloc;
  	}