Skip to contentSkip to conversation

powerpc: Fix fall-through warning for Clang

PATCH Applied Gustavo A. R. Silva 4 participants 4 messages Sep 6, 2022 – Sep 23, 2022

Subsystems (2)
PowerPC Linux for PowerPC embedded PPC85XX
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 powerpc: Fix fall-through warning for Clang

Fix the following fallthrough warning:

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Link https://github.com/KSPP/linux/issues/198
Reported-by kernel test robot <[email protected]>
Link https://lore.kernel.org/lkml/[email protected]/ open here
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 arch/powerpc/platforms/85xx/mpc85xx_cds.c | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/85xx/mpc85xx_cds.c +1 -0
index 48f3acfece0b..0b8f2101c5fb 100644
@@ -159,6 +159,7 @@ static void __init mpc85xx_cds_pci_irq_fixup(struct pci_dev *dev)
 			else
 				dev->irq = 10;
 			pci_write_config_byte(dev, PCI_INTERRUPT_LINE, dev->irq);
+			break;
 		default:
 			break;
 		}
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Gustavo A. R. Silva

Fix the following fallthrough warning:

arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]

Link https://github.com/KSPP/linux/issues/198
Reported-by kernel test robot <[email protected]>
Link https://lore.kernel.org/lkml/[email protected]/ open here
Signed-off-by Gustavo A. R. Silva <[email protected]>

Thanks!

Reviewed-by Kees Cook <[email protected]>
Signature · 1 line
Kees Cook