Skip to contentSkip to conversation

scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages Sep 22, 2022 – Sep 25, 2022 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: hptiop: Replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command

One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command.

---
 drivers/scsi/hptiop.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/hptiop.h +1 -1
index ef2f2aca598c..394ef6aa469e 100644
@@ -237,7 +237,7 @@ struct hpt_iop_request_ioctl_command {
 	__le32 inbuf_size;
 	__le32 outbuf_size;
 	__le32 bytes_returned;
-	u8     buf[1];
+	u8     buf[];
 	/* out data should be put at buf[(inbuf_size+3)&~3] */
 };
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Gustavo A. R. Silva

One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command.

I see no binary differences with the patch, so that's good! :)

Signature · 1 line
Kees Cook
#2 lore raw
In reply to Gustavo A. R. Silva

Gustavo,

Quoted 3 lines

One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element array with flexible-array member in struct hpt_iop_request_ioctl_command.

Applied to 6.1/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering