nvme-loop: Avoid -Wflex-array-member-not-at-end warning
Subsystems (2)
PATCH 1/1 nvme-loop: Avoid -Wflex-array-member-not-at-end warning
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice that struct nvme_loop_iod is a flexible structure --a structure that contains a flexible-array member.
Fix the following warning:
drivers/nvme/target/loop.c:36:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
--- drivers/nvme/target/loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/nvme/target/loop.c +3 -1
@@ -33,10 +33,12 @@ struct nvme_loop_ctrl {struct list_head list;struct blk_mq_tag_set tag_set; -struct nvme_loop_iod async_event_iod;struct nvme_ctrl ctrl;struct nvmet_port *port; + +/* Must be last --ends in a flexible-array member. */ +struct nvme_loop_iod async_event_iod; };static inline struct nvme_loop_ctrl *to_loop_ctrl (struct nvme_ctrl *ctrl)
Signature · 1 line
2.43.0
Quoted 6 lines · Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice that
struct nvme_loop_iodis a flexible structure --a structure that contains a flexible-array member.
Indeed :-
18 struct nvme_loop_iod {
19 struct nvme_request nvme_req;
20 struct nvme_command cmd;
21 struct nvme_completion cqe;
22 struct nvmet_req req;
23 struct nvme_loop_queue *queue;
24 struct work_struct work;
25 struct sg_table sg_table;
26 struct scatterlist first_sgl[];
27 };
Quoted 5 lines
Fix the following warning:
drivers/nvme/target/loop.c:36:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]Signed-off-by Gustavo A. R. Silva<[email protected]>
Looks good.
-ck
Looks good:
Hi all,
Friendly ping: who can take this patch, please? :)
Thanks!
-Gustavo
Quoted 34 lines · Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice that
struct nvme_loop_iodis a flexible structure --a structure that contains a flexible-array member.Fix the following warning:
drivers/nvme/target/loop.c:36:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/nvme/target/loop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/nvme/target/loop.c +3
-1@@ -33,10 +33,12 @@ struct nvme_loop_ctrl {struct list_head list;struct blk_mq_tag_set tag_set; -struct nvme_loop_iod async_event_iod;struct nvme_ctrl ctrl;struct nvmet_port *port; + +/* Must be last --ends in a flexible-array member. */ +struct nvme_loop_iod async_event_iod; };static inline struct nvme_loop_ctrl *to_loop_ctrl (struct nvme_ctrl *ctrl)
Christoph Hellwig
maintainerQuoted 3 lines · Gustavo A. R. Silva
Hi all,
Friendly ping: who can take this patch, please? :)
This will go into the 6.16 nvme branch as soon as it opens.
Thanks,
applied to nvme-6.16.
Quoted 6 lines · Christoph Hellwig
Quoted 3 lines · Gustavo A. R. Silva
Hi all,
Friendly ping: who can take this patch, please? :)
This will go into the 6.16 nvme branch as soon as it opens.
Awesome. :)
Thanks
-Gustavo