Skip to contentSkip to conversation

ledtrig_flash_ctrl and ledtrig_torch_ctrl

DISCUSSION Dr. David Alan Gilbert 2 participants 3 messages Jan 26, 2025 – Feb 10, 2025 LED

lore
Share & tools
lore
#0 lore raw

Hi,
One of my scripts noticed that ledtrig_flash_ctrl() and
ledtrig_torch_ctrl() don't seem to be called anywhere, and don't seem to have been since they were added in 2013.

Are they actually deadcode I can/should remove?

Dave

Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/
maintainer
#1 lore raw
Quoted 6 lines · Dr. David Alan Gilbert

Hi,
One of my scripts noticed that ledtrig_flash_ctrl() and
ledtrig_torch_ctrl() don't seem to be called anywhere, and don't seem to have been since they were added in 2013.

Are they actually deadcode I can/should remove?

I would ping the authors first. If there are no good reasons to keep them around come back, you can remove them.

Signature · 1 line
Lee Jones [李琼斯]
#2 lore raw

Copying in Milo

Quoted 11 lines · * Lee Jones ([email protected]) wrote:
Quoted 6 lines · Dr. David Alan Gilbert

Hi,
One of my scripts noticed that ledtrig_flash_ctrl() and
ledtrig_torch_ctrl() don't seem to be called anywhere, and don't seem to have been since they were added in 2013.

Are they actually deadcode I can/should remove?

I would ping the authors first. If there are no good reasons to keep them around come back, you can remove them.

OK, copied in.

Dave

Quoted 2 lines
Signature · 1 line
Lee Jones [李琼斯]
Signature · 4 lines
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/