Skip to contentSkip to conversation

afs: Add missing init for srx_service member

PATCH New Cyrill Gorcunov 1 participant 1 message Jan 30, 2025 Afs filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 afs: Add missing init for srx_service member

Both afs_merge_fs_addr4 and afs_merge_fs_addr6 helpers allocate sockaddr_rxrpc structure on kernel stack and never init srx_service member before passing it down for peer lookup/creation. Looks insignificant in current context but better be on a safe side for future use. Thus initialize them explicitly.

Cc David Howells <[email protected]>
Cc Marc Dionne <[email protected]>
---
 fs/afs/addr_list.c |    2 ++
 1 file changed, 2 insertions(+)
fs/afs/addr_list.c +2 -0
Index: linux-tip.git/fs/afs/addr_list.c
===================================================================
@@ -291,6 +291,7 @@ int afs_merge_fs_addr4(struct afs_net *n
 		return 0;
 
 	srx.srx_family = AF_RXRPC;
+	srx.srx_service = 0;
 	srx.transport_type = SOCK_DGRAM;
 	srx.transport_len = sizeof(srx.transport.sin);
 	srx.transport.sin.sin_family = AF_INET;
@@ -335,6 +336,7 @@ int afs_merge_fs_addr6(struct afs_net *n
 		return 0;
 
 	srx.srx_family = AF_RXRPC;
+	srx.srx_service = 0;
 	srx.transport_type = SOCK_DGRAM;
 	srx.transport_len = sizeof(srx.transport.sin6);
 	srx.transport.sin6.sin6_family = AF_INET6;