Skip to contentSkip to conversation

staging: gpib: format no multiple blank lines

PATCH In review Ian To 3 participants 3 messages Jan 31, 2025 – Feb 3, 2025 Staging

lore
Share & tools
lore

Ian To

author
#0 lore raw

PATCH 1/1 staging: gpib: format no multiple blank lines

Avoid adding multiple blank lines. Reported by checkpatch.

---
 drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/hp_82341/hp_82341.h +0 -1
index 0065ebd9747c..d3cf1f43a1ef 100644
@@ -26,7 +26,6 @@ struct hp_82341_priv {
 	enum hp_82341_hardware_version hw_version;
 };
 
-
 // interface functions
 int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
 			size_t *bytes_read);
Signature · 1 line
2.45.3
maintainer
#1 lore raw
Quoted 23 lines · Ian To

Avoid adding multiple blank lines. Reported by checkpatch.

---
 drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/hp_82341/hp_82341.h +0 -1
index 0065ebd9747c..d3cf1f43a1ef 100644
@@ -26,7 +26,6 @@ struct hp_82341_priv {
 	enum hp_82341_hardware_version hw_version;
 };
 
-
 // interface functions
 int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
 			size_t *bytes_read);
Signature · 1 line
2.45.3

Does not apply cleanly to 6.14-rc1 :(

#2 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Ian To

Avoid adding multiple blank lines. Reported by checkpatch.

---
 drivers/staging/gpib/hp_82341/hp_82341.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/gpib/hp_82341/hp_82341.h +0 -0
index 0065ebd9747c..d3cf1f43a1ef 100644
@@ -26,7 +26,6 @@ struct hp_82341_priv {
 	enum hp_82341_hardware_version hw_version;
 };
 
Quoted 10 lines
Quoted 8 lines
drivers/staging/gpib/hp_82341/hp_82341.h +0 -1
-
 // interface functions
 int hp_82341_accel_read(gpib_board_t *board, uint8_t *buffer, size_t length, int *end,
 			size_t *bytes_read);
Signature · 1 line
2.45.3

Does not apply cleanly to 6.14-rc1 :(

An earlier patch, commit 8418753187ba ("staging: gpib: Make static, reduce fwd declarations") changed this file. It is at this point checkpatch clean. cheers,
-dave