dt-bindings: arm: rockchip: Add MNT Reform 2 (RCORE)

Document board compatible bindings.

---
Changes for v2:
- No changes, apart from Acked-by

 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

index 522a6f0450ea..bc995db8cbfe 100644
@@ -710,6 +710,11 @@ properties:
           - const: mqmaker,miqi
           - const: rockchip,rk3288
 
+      - description: MNT Reform2 (RCORE)
+        items:
+          - const: mntre,reform2-rcore
+          - const: rockchip,rk3588
+
       - description: Neardi LBA3368
         items:
           - const: neardi,lba3368

2.48.1

MNT Reform 2 is an open source laptop with replaceable CPU modules, including a version with the RK3588-based MNT RCORE[1]:

- Rockchip RK3588
- Quad A76 and Quad A55 CPU
- 6 TOPS NPU
- up to 32GB LPDDR4x RAM
- SD Card slot
- Gigabit ethernet port
- HDMI port
- 2x mPCIe ports for WiFi or NVMe
- 3x USB 3.0 Type-A HOST port

[1] https://shop.mntre.com/products/mnt-reform

---
Changes for v2:
- Aligned with bindings and schemas to appease DTB check warnings.
- Aligned with format of other RK3588 boards for consistency.

 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3588-mnt-reform2.dts  | 785 ++++++++++++++++++
 2 files changed, 786 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-mnt-reform2.dts

index def1222c1907..88381d9a20e3 100644
@@ -145,6 +145,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-firefly-itx-3588j.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-friendlyelec-cm3588-nas.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-h96-max-v58.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-jaguar.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-mnt-reform2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6-lts.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb

2.48.1

The RCORE looks like a carrier board for the Firefly iCore RK3588Q SoM [1]. So it would be better to restructure the DTS as a dtsi for the SoM and a board DTS which includes the SoM dtsi.

That's similar to the structure of the Firefly ITX-RK3558J board which uses the rk3588-firefly-core-3588j.dtsi. [2]

[1] https://source.mnt.re/reform/mnt-reform-rk3588-som
[2] https://lore.kernel.org/linux-rockchip/[email protected]/#t

Hi Jimmy,

Am Dienstag, 11. Februar 2025, 05:03:00 MEZ schrieb Jimmy Hon:

thanks a lot for finding that bit of information.

And I do agree that if there is a Firefly module in the middle, that things should be modelled accordingly.

Heiko