Skip to contentSkip to conversation

staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided

PATCH Superseded Michael Anckaert 2 participants 2 messages Feb 12, 2025

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Michael Anckaert

author
#0 lore raw

PATCH 1/1 staging: sm750fb: fix checkpatch warning architecture specific defines should be avoided

Replace architecture-specific defines with CONFIG_X86 checks to improve portability and adhere to kernel coding standards.

Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.

Changes made:
- Using CONFIG_X86 instead of i386 and x86.

Signed-off-by Michael Anckaert <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +1 -1
index 02860d3ec365..67a2f60440ca 100644
@@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
 		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
 		poke32(VGA_CONFIGURATION, reg);
 	} else {
-#if defined(__i386__) || defined(__x86_64__)
+#ifdef CONFIG_X86
 		/* set graphic mode via IO method */
 		outb_p(0x88, 0x3d4);
 		outb_p(0x06, 0x3d5);
Signature · 1 line
2.39.5
Reviewed-by on v1 1/1
#1 lore raw

Hi

Am 12.02.25 um 08:43 schrieb Michael Anckaert:

Quoted 19 lines

Replace architecture-specific defines with CONFIG_X86 checks to improve portability and adhere to kernel coding standards.

Fixes checkpatch warning:
- CHECK: architecture specific defines should be avoided.

Changes made:
- Using CONFIG_X86 instead of i386 and x86.

Signed-off-by Michael Anckaert <[email protected]>
---
  drivers/staging/sm750fb/ddk750_chip.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm750fb/ddk750_chip.c +0 -0
index 02860d3ec365..67a2f60440ca 100644

drivers/staging/sm750fb/ddk750_chip.c int ddk750_init_hw(struct initchip_param *p_init_param) · line 235

Quoted 8 lines
drivers/staging/sm750fb/ddk750_chip.c +1 -1
@@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
  		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
  		poke32(VGA_CONFIGURATION, reg);
  	} else {
-#if defined(__i386__) || defined(__x86_64__)
+#ifdef CONFIG_X86
  		/* set graphic mode via IO method */
  		outb_p(0x88, 0x3d4);
  		outb_p(0x06, 0x3d5);

Maybe move the '} else {' into the ifdef to avoid the possibly empty else branch. I also wonder why this is only being done on x86. There are other systems with VGA.

In any case

Reviewed-by Thomas Zimmermann <[email protected]>

Best regards
Thomas

Signature · 7 lines
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)