Skip to contentSkip to conversation

staging: sm750: Rename camel case functions in sm750_cursor.*

PATCH Kloudifold 2 participants 2 messages Mar 10, 2023 Staging

lore
Share & tools
lore

Kloudifold

author
#0 lore raw

Thank you for your advice! Should I change this patch and patch message and resend it?

Quoted 55 lines · Julia Lawall

You don't need the filename in the subject.

Quoted 39 lines · Kloudifold

This patch fixes the "CHECK: Avoid CamelCase" reported by checkpatch.pl by renaming camel case functions.

---
 drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++-------
 drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------
 2 files changed, 13 insertions(+), 13 deletions(-)
drivers/staging/sm750fb/sm750_cursor.c +3 -3
index 43e6f52c2..ff643e33f 100644
@@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor)
      poke32(HWC_ADDRESS, 0);
 }
 
-void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h)
+void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h)
 {
      cursor->w = w;
      cursor->h = h;
 }
 
-void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)
+void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y)
 {
      u32 reg;
 
@@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)
      poke32(HWC_LOCATION, reg);
 }
 
-void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)
+void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg)
 {
      u32 reg = (fg << HWC_COLOR_12_2_RGB565_SHIFT) &
              HWC_COLOR_12_2_RGB565_MASK;

drivers/staging/sm750fb/sm750_cursor.c void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) · line 86

Quoted 7 lines
drivers/staging/sm750fb/sm750_cursor.c +2 -2
@@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)
      poke32(HWC_COLOR_3, 0xffe0);
 }
 
-void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
-                          const u8 *pcol, const u8 *pmsk)
+void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop,
+                           const u8 *pcol, const u8 *pmsk)

The indentation of the second line looks random. It's not a multiple of the tabs, and it doesn't line up with the right side of the (. So there doesn't seem to be any need to change it for this patch.

#1 lore raw
Quoted 2 lines · Kloudifold

Thank you for your advice! Should I change this patch and patch message and resend it?

Yes please. But don't top post.

Also, you have the same strange reply to line in your message as I mentioned for someone else recently. Perhaps derived from the same mutt configuration?

julia

Quoted 59 lines · Julia Lawall
Quoted 55 lines

You don't need the filename in the subject.

Quoted 39 lines · Kloudifold

This patch fixes the "CHECK: Avoid CamelCase" reported by checkpatch.pl by renaming camel case functions.

---
 drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++-------
 drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------
 2 files changed, 13 insertions(+), 13 deletions(-)
drivers/staging/sm750fb/sm750_cursor.c +3 -3
index 43e6f52c2..ff643e33f 100644
@@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor)
      poke32(HWC_ADDRESS, 0);
 }
 
-void sm750_hw_cursor_setSize(struct lynx_cursor *cursor, int w, int h)
+void sm750_hw_cursor_set_size(struct lynx_cursor *cursor, int w, int h)
 {
      cursor->w = w;
      cursor->h = h;
 }
 
-void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)
+void sm750_hw_cursor_set_pos(struct lynx_cursor *cursor, int x, int y)
 {
      u32 reg;
 
@@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)
      poke32(HWC_LOCATION, reg);
 }
 
-void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)
+void sm750_hw_cursor_set_color(struct lynx_cursor *cursor, u32 fg, u32 bg)
 {
      u32 reg = (fg << HWC_COLOR_12_2_RGB565_SHIFT) &
              HWC_COLOR_12_2_RGB565_MASK;

drivers/staging/sm750fb/sm750_cursor.c void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg) · line 86

Quoted 7 lines
drivers/staging/sm750fb/sm750_cursor.c +2 -2
@@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)
      poke32(HWC_COLOR_3, 0xffe0);
 }
 
-void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
-                          const u8 *pcol, const u8 *pmsk)
+void sm750_hw_cursor_set_data(struct lynx_cursor *cursor, u16 rop,
+                           const u8 *pcol, const u8 *pmsk)

The indentation of the second line looks random. It's not a multiple of the tabs, and it doesn't line up with the right side of the (. So there doesn't seem to be any need to change it for this patch.