staging: sm750: Rename camel case functions
Subsystems (2)
PATCH 1/1 staging: sm750: Rename camel case functions
This patch fixes the "CHECK: Avoid CamelCase" reported by checkpatch.pl by renaming camel case functions in sm750_cursor.c and sm750_cursor.h.
Modified calls to functions declared in sm750_cursor.h in sm750.c.
Fixed issue in [PATCH] staging: sm750: Rename camel case functions in sm750_cursor.* | Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
--- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++------- drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------ 3 files changed, 24 insertions(+), 24 deletions(-)
drivers/staging/sm750fb/sm750.c +11 -11
@@ -121,14 +121,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)sm750_hw_cursor_disable (cursor);if (fbcursor->set &FB_CUR_SETSIZE ) -sm750_hw_cursor_setSize (cursor, - fbcursor->image.width, - fbcursor->image.height); +sm750_hw_cursor_set_size (cursor, + fbcursor->image.width, + fbcursor->image.height);if (fbcursor->set &FB_CUR_SETPOS ) -sm750_hw_cursor_setPos (cursor, - fbcursor->image.dx - info->var.xoffset, - fbcursor->image.dy - info->var.yoffset); +sm750_hw_cursor_set_pos (cursor, + fbcursor->image.dx - info->var.xoffset, + fbcursor->image.dy - info->var.yoffset);if (fbcursor->set &FB_CUR_SETCMAP ) {/* get the 16bit color of kernel means */
@@ -142,14 +142,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) ((info->cmap.green[fbcursor->image.bg_color] &0xfc00 ) >>5 ) | ((info->cmap.blue[fbcursor->image.bg_color] &0xf800 ) >>11 ); -sm750_hw_cursor_setColor (cursor, fg, bg); +sm750_hw_cursor_set_color (cursor, fg, bg); }if (fbcursor->set & (FB_CUR_SETSHAPE |FB_CUR_SETIMAGE )) { -sm750_hw_cursor_setData (cursor, - fbcursor->rop, - fbcursor->image.data, - fbcursor->mask); +sm750_hw_cursor_set_data (cursor, + fbcursor->rop, + fbcursor->image.data, + fbcursor->mask); }if (fbcursor->enable)
drivers/staging/sm750fb/sm750_cursor.c +7 -7
@@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor)poke32 (HWC_ADDRESS ,0 ); } -void sm750_hw_cursor_setSize (struct lynx_cursor *cursor,int w,int h) +void sm750_hw_cursor_set_size (struct lynx_cursor *cursor,int w,int h) { cursor->w = w; cursor->h = h; } -void sm750_hw_cursor_setPos (struct lynx_cursor *cursor,int x,int y) +void sm750_hw_cursor_set_pos (struct lynx_cursor *cursor,int x,int y) {u32 reg;
@@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)poke32 (HWC_LOCATION , reg); } -void sm750_hw_cursor_setColor (struct lynx_cursor *cursor,u32 fg,u32 bg) +void sm750_hw_cursor_set_color (struct lynx_cursor *cursor,u32 fg,u32 bg) {u32 reg = (fg <<HWC_COLOR_12_2_RGB565_SHIFT ) &HWC_COLOR_12_2_RGB565_MASK ;
@@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)poke32 (HWC_COLOR_3 ,0xffe0 ); } -void sm750_hw_cursor_setData (struct lynx_cursor *cursor,u16 rop, -const u8 *pcol,const u8 *pmsk) +void sm750_hw_cursor_set_data (struct lynx_cursor *cursor,u16 rop, +const u8 *pcol,const u8 *pmsk) {int i, j, count, pitch, offset;u8 color, mask, opr;
@@ -132,8 +132,8 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2 (struct lynx_cursor *cursor,u16 rop, -const u8 *pcol,const u8 *pmsk) +void sm750_hw_cursor_set_data2 (struct lynx_cursor *cursor,u16 rop, +const u8 *pcol,const u8 *pmsk) {int i, j, count, pitch, offset;u8 color, mask;
drivers/staging/sm750fb/sm750_cursor.h +6 -6
@@ -5,11 +5,11 @@/* hw_cursor_xxx works for voyager,718 and 750 */ void sm750_hw_cursor_enable (struct lynx_cursor *cursor);void sm750_hw_cursor_disable (struct lynx_cursor *cursor); -void sm750_hw_cursor_setSize (struct lynx_cursor *cursor,int w,int h); -void sm750_hw_cursor_setPos (struct lynx_cursor *cursor,int x,int y); -void sm750_hw_cursor_setColor (struct lynx_cursor *cursor,u32 fg,u32 bg); -void sm750_hw_cursor_setData (struct lynx_cursor *cursor,u16 rop, -const u8 *data,const u8 *mask); -void sm750_hw_cursor_setData2 (struct lynx_cursor *cursor,u16 rop, +void sm750_hw_cursor_set_size (struct lynx_cursor *cursor,int w,int h); +void sm750_hw_cursor_set_pos (struct lynx_cursor *cursor,int x,int y); +void sm750_hw_cursor_set_color (struct lynx_cursor *cursor,u32 fg,u32 bg); +void sm750_hw_cursor_set_data (struct lynx_cursor *cursor,u16 rop,const u8 *data,const u8 *mask); +void sm750_hw_cursor_set_data2 (struct lynx_cursor *cursor,u16 rop, +const u8 *data,const u8 *mask);#endif
Signature · 1 line
2.39.2
Quoted 11 lines · Kloudifold
This patch fixes the "CHECK: Avoid CamelCase" reported by checkpatch.pl by renaming camel case functions in
sm750_cursor.candsm750_cursor.h.
Modified calls to functions declared insm750_cursor.hinsm750.c.Fixed issue in [PATCH] staging: sm750: Rename camel case functions in sm750_cursor.* | Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/Signed-off-by Kloudifold <[email protected]>---
No, you're going to need to resend a v2 patch.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please slow down. It's explained in my blog, but you should not send any more patches until tomorrow. It gives people more time to respond to the original patch. Also if you wait until tomorrow everyone will assume you are testing everything overnight.
regards,
dan carpenter
Quoted 4 lines · Kloudifold
This patch fixes the "CHECK: Avoid CamelCase" reported by checkpatch.pl by renaming camel case functions in
sm750_cursor.candsm750_cursor.h.
Modified calls to functions declared insm750_cursor.hinsm750.c.
Kloudifold,
Please go back and read the entire Outreachy patch tutorial. It explains clearly how to update a patch when you have gotten some feedback about it. It also explains how to write a good log message.
With respect to your log message here, you never need to say "This patch". It's clear that wat you are talking about a patch. Please try to avoid the word "fix". As in this case, it naturally leads one to not actually explaining what is done. It is useful to acknowledge that checkpatch helped you find the problem, and perhaps useful to provide the checkpatch warning, but put all that at the end. Explain what you have done and why first, because that is most interesting to the reader. There is no need to mention the file names in the log message. That information is easily available in the diffstat below. And the log message should be written in the imperative (eg Modify) not the past tense (Modified).
You may find it helpful to look at other patches (git log -p) to get a feel for the expected style.
julia
Quoted 135 lines
Fixed issue in [PATCH] staging: sm750: Rename camel case functions in sm750_cursor.* | Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/Signed-off-by Kloudifold <[email protected]>--- drivers/staging/sm750fb/sm750.c | 22 +++++++++++----------- drivers/staging/sm750fb/sm750_cursor.c | 14 +++++++------- drivers/staging/sm750fb/sm750_cursor.h | 12 ++++++------ 3 files changed, 24 insertions(+), 24 deletions(-)drivers/staging/sm750fb/sm750.c +11
-11@@ -121,14 +121,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor)sm750_hw_cursor_disable (cursor);if (fbcursor->set &FB_CUR_SETSIZE ) -sm750_hw_cursor_setSize (cursor, - fbcursor->image.width, - fbcursor->image.height); +sm750_hw_cursor_set_size (cursor, + fbcursor->image.width, + fbcursor->image.height);if (fbcursor->set &FB_CUR_SETPOS ) -sm750_hw_cursor_setPos (cursor, - fbcursor->image.dx - info->var.xoffset, - fbcursor->image.dy - info->var.yoffset); +sm750_hw_cursor_set_pos (cursor, + fbcursor->image.dx - info->var.xoffset, + fbcursor->image.dy - info->var.yoffset);if (fbcursor->set &FB_CUR_SETCMAP ) {/* get the 16bit color of kernel means */ @@ -142,14 +142,14 @@ static int lynxfb_ops_cursor(struct fb_info *info, struct fb_cursor *fbcursor) ((info->cmap.green[fbcursor->image.bg_color] &0xfc00 ) >>5 ) | ((info->cmap.blue[fbcursor->image.bg_color] &0xf800 ) >>11 ); -sm750_hw_cursor_setColor (cursor, fg, bg); +sm750_hw_cursor_set_color (cursor, fg, bg); }if (fbcursor->set & (FB_CUR_SETSHAPE |FB_CUR_SETIMAGE )) { -sm750_hw_cursor_setData (cursor, - fbcursor->rop, - fbcursor->image.data, - fbcursor->mask); +sm750_hw_cursor_set_data (cursor, + fbcursor->rop, + fbcursor->image.data, + fbcursor->mask); }if (fbcursor->enable)drivers/staging/sm750fb/sm750_cursor.c +7
-7@@ -58,13 +58,13 @@ void sm750_hw_cursor_disable(struct lynx_cursor *cursor)poke32 (HWC_ADDRESS ,0 ); } -void sm750_hw_cursor_setSize (struct lynx_cursor *cursor,int w,int h) +void sm750_hw_cursor_set_size (struct lynx_cursor *cursor,int w,int h) { cursor->w = w; cursor->h = h; } -void sm750_hw_cursor_setPos (struct lynx_cursor *cursor,int x,int y) +void sm750_hw_cursor_set_pos (struct lynx_cursor *cursor,int x,int y) {u32 reg;@@ -73,7 +73,7 @@ void sm750_hw_cursor_setPos(struct lynx_cursor *cursor, int x, int y)poke32 (HWC_LOCATION , reg); } -void sm750_hw_cursor_setColor (struct lynx_cursor *cursor,u32 fg,u32 bg) +void sm750_hw_cursor_set_color (struct lynx_cursor *cursor,u32 fg,u32 bg) {u32 reg = (fg <<HWC_COLOR_12_2_RGB565_SHIFT ) &HWC_COLOR_12_2_RGB565_MASK ;@@ -82,8 +82,8 @@ void sm750_hw_cursor_setColor(struct lynx_cursor *cursor, u32 fg, u32 bg)poke32 (HWC_COLOR_3 ,0xffe0 ); } -void sm750_hw_cursor_setData (struct lynx_cursor *cursor,u16 rop, -const u8 *pcol,const u8 *pmsk) +void sm750_hw_cursor_set_data (struct lynx_cursor *cursor,u16 rop, +const u8 *pcol,const u8 *pmsk) {int i, j, count, pitch, offset;u8 color, mask, opr;@@ -132,8 +132,8 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop, } } -void sm750_hw_cursor_setData2 (struct lynx_cursor *cursor,u16 rop, -const u8 *pcol,const u8 *pmsk) +void sm750_hw_cursor_set_data2 (struct lynx_cursor *cursor,u16 rop, +const u8 *pcol,const u8 *pmsk) {int i, j, count, pitch, offset;u8 color, mask;drivers/staging/sm750fb/sm750_cursor.h +6
-7@@ -5,11 +5,11 @@/* hw_cursor_xxx works for voyager,718 and 750 */ void sm750_hw_cursor_enable (struct lynx_cursor *cursor);void sm750_hw_cursor_disable (struct lynx_cursor *cursor); -void sm750_hw_cursor_setSize (struct lynx_cursor *cursor,int w,int h); -void sm750_hw_cursor_setPos (struct lynx_cursor *cursor,int x,int y); -void sm750_hw_cursor_setColor (struct lynx_cursor *cursor,u32 fg,u32 bg); -void sm750_hw_cursor_setData (struct lynx_cursor *cursor,u16 rop, -const u8 *data,const u8 *mask); -void sm750_hw_cursor_setData2 (struct lynx_cursor *cursor,u16 rop, +void sm750_hw_cursor_set_size (struct lynx_cursor *cursor,int w,int h); +void sm750_hw_cursor_set_pos (struct lynx_cursor *cursor,int x,int y); +void sm750_hw_cursor_set_color (struct lynx_cursor *cursor,u32 fg,u32 bg); +void sm750_hw_cursor_set_data (struct lynx_cursor *cursor,u16 rop,const u8 *data,const u8 *mask); +void sm750_hw_cursor_set_data2 (struct lynx_cursor *cursor,u16 rop, +const u8 *data,const u8 *mask);#endif --2.39.2