wifi: rndis_wlan: Replace fake flex-array with flexible-array member
Subsystems (3)
PATCH 1/1 wifi: rndis_wlan: Replace fake flex-array with flexible-array member
Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead.
Address the following warning found with GCC-13 and
-fstrict-flex-array=3 enabled:drivers/net/wireless/rndis_wlan.c:2902:23: warning: array subscript 0 is outside array bounds of ‘struct ndis_80211_auth_request[0]’ [-Warray-bounds=]
This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].
--- drivers/net/wireless/legacy/rndis_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/legacy/rndis_wlan.c +1 -1
@@ -209,7 +209,7 @@ struct ndis_80211_status_indication {union {__le32 media_stream_mode;__le32 radio_status; -struct ndis_80211_auth_request auth_request[0 ]; + DECLARE_FLEX_ARRAY(struct ndis_80211_auth_request, auth_request);struct ndis_80211_pmkid_cand_list cand_list; } u; } __packed;
Signature · 1 line
2.34.1
Hi all,
Friendly ping: who can take this, please? 😄
Thanks
Signature · 1 line
Gustavo
Quoted 32 lines · Gustavo A. R. Silva
Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead.
Address the following warning found with GCC-13 and
-fstrict-flex-array=3 enabled:drivers/net/wireless/rndis_wlan.c:2902:23: warning: array subscript 0 is outside array bounds of ‘struct ndis_80211_auth_request[0]’ [-Warray-bounds=]This helps with the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy()and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/wireless/legacy/rndis_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/wireless/legacy/rndis_wlan.c +1
-1@@ -209,7 +209,7 @@ struct ndis_80211_status_indication {union {__le32 media_stream_mode;__le32 radio_status; -struct ndis_80211_auth_request auth_request[0 ]; + DECLARE_FLEX_ARRAY(struct ndis_80211_auth_request, auth_request);struct ndis_80211_pmkid_cand_list cand_list; } u; } __packed;
Quoted 7 lines · Gustavo A. R. Silva
Zero-length arrays as fake flexible arrays are deprecated and we are moving towards adopting C99 flexible-array members instead.
Address the following warning found with GCC-13 and
-fstrict-flex-array=3 enabled:drivers/net/wireless/rndis_wlan.c:2902:23: warning: array subscript 0 is outside array bounds of ‘struct ndis_80211_auth_request[0]’ [-Warray-bounds=]
Quoted 8 lines
This helps with the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy()and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].
Patch applied to wireless-next.git, thanks.
06dabcccc08b wifi: rndis_wlan: Replace fake flex-array with flexible-array member
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/ZBtIbU77L9eXqa4j@work/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches