cifs: double lock in cifs_reconnect_tcon()
Subsystems (3)
PATCH 1/1 cifs: double lock in cifs_reconnect_tcon()
This lock was supposed to be an unlock.
Fixes 6cc041e90c17 ("cifs: avoid races in parallel reconnects in smb1")
Signed-off-by Dan Carpenter <[email protected]>
--- fs/cifs/cifssmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/cifssmb.c +1 -1
@@ -120,7 +120,7 @@ cifs_reconnect_tcon(struct cifs_tcon *tcon, int smb_command)spin_lock (&server->srv_lock);if (server->tcpStatus == CifsNeedReconnect) {spin_unlock (&server->srv_lock); -mutex_lock (&ses->session_mutex); +mutex_unlock (&ses->session_mutex);if (tcon->retry) goto again;
Signature · 1 line
2.39.1
Quoted 7 lines · Dan Carpenter
This lock was supposed to be an unlock.
Fixes 6cc041e90c17 ("cifs: avoid races in parallel reconnects in smb1")Signed-off-by Dan Carpenter <[email protected]>--- fs/cifs/cifssmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Paulo Alcantara (SUSE) <[email protected]>
Added to cifs-2.6.git for-next
Quoted 12 lines · Paulo Alcantara
Quoted 7 lines · Dan Carpenter
This lock was supposed to be an unlock.
Fixes 6cc041e90c17 ("cifs: avoid races in parallel reconnects in smb1")Signed-off-by Dan Carpenter <[email protected]>--- fs/cifs/cifssmb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Reviewed-by Paulo Alcantara (SUSE) <[email protected]>
Signature · 3 lines
Thanks, Steve