Skip to contentSkip to conversation

cifs: double lock in cifs_reconnect_tcon()

PATCH In review Dan Carpenter 3 participants 3 messages Apr 6, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cifs: double lock in cifs_reconnect_tcon()

This lock was supposed to be an unlock.

Fixes 6cc041e90c17 ("cifs: avoid races in parallel reconnects in smb1")
---
 fs/cifs/cifssmb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/cifssmb.c +1 -1
index 0d30b17494e4..9d963caec35c 100644
@@ -120,7 +120,7 @@ cifs_reconnect_tcon(struct cifs_tcon *tcon, int smb_command)
 	spin_lock(&server->srv_lock);
 	if (server->tcpStatus == CifsNeedReconnect) {
 		spin_unlock(&server->srv_lock);
-		mutex_lock(&ses->session_mutex);
+		mutex_unlock(&ses->session_mutex);
 
 		if (tcon->retry)
 			goto again;
Signature · 1 line
2.39.1