Skip to contentSkip to conversation

staging: ks7010: remove unnecesary parentheses

PATCH In review Joel Camilo Chang Gonzalez 2 participants 4 messages Mar 30, 2023 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: ks7010: remove unnecesary parentheses

Remove parentheses not needed in if statement

---
 drivers/staging/ks7010/ks_hostif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_hostif.c +1 -1
index af3825578d85..8bded7e88ce7 100644
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
 	size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
 		ap_info->rsn.size : RSN_IE_BODY_MAX;
 	if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
-	    (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+	    priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {
 		ap->rsn_ie.id = RSN_INFO_ELEM_ID;
 		ap->rsn_ie.size = size;
 		memcpy(ap->rsn_ie.body, ap_info->rsn.body, size);
Signature · 1 line
2.37.2
maintainer
#1 lore raw
Quoted 12 lines · Joel Camilo Chang Gonzalez

Remove parentheses not needed in if statement

---
 drivers/staging/ks7010/ks_hostif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_hostif.c +0 -0
index af3825578d85..8bded7e88ce7 100644

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) · line 132

Quoted 5 lines
drivers/staging/ks7010/ks_hostif.c +1 -1
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
 	size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
 		ap_info->rsn.size : RSN_IE_BODY_MAX;
 	if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
-	    (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+	    priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {

If you look in the archives, you will see that I reject this type of patch all the time.

Also, please use scripts/get_maintainer.pl to determine who to send this to, you used a very old mailing list address that is long dead.

thanks,

greg k-h

#2 lore raw
Quoted 22 lines · Greg KH
Quoted 12 lines · Joel Camilo Chang Gonzalez

Remove parentheses not needed in if statement

---
 drivers/staging/ks7010/ks_hostif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_hostif.c +0 -0
index af3825578d85..8bded7e88ce7 100644

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) · line 132

Quoted 5 lines
drivers/staging/ks7010/ks_hostif.c +1 -1
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
 	size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
 		ap_info->rsn.size : RSN_IE_BODY_MAX;
 	if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
-	    (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+	    priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {

If you look in the archives, you will see that I reject this type of patch all the time.

Quoted 6 lines

Also, please use scripts/get_maintainer.pl to determine who to send this to, you used a very old mailing list address that is long dead.

thanks,

greg k-h

Thanks for the input. I wasn't sure who to send it to, since the TODO in the driver and the script have different email addresses.

Is there a place to check for inactive mailing lists?

maintainer
#3 lore raw
Quoted 26 lines · Joel C. Chang
Quoted 25 lines · Greg KH
Quoted 12 lines · Joel Camilo Chang Gonzalez

Remove parentheses not needed in if statement

---
 drivers/staging/ks7010/ks_hostif.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ks7010/ks_hostif.c +0 -0
index af3825578d85..8bded7e88ce7 100644

drivers/staging/ks7010/ks_hostif.c int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info) · line 132

Quoted 5 lines
drivers/staging/ks7010/ks_hostif.c +1 -1
@@ -129,7 +129,7 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info *ap_info)
 	size = (ap_info->rsn.size <= RSN_IE_BODY_MAX) ?
 		ap_info->rsn.size : RSN_IE_BODY_MAX;
 	if ((ap_info->rsn_mode & RSN_MODE_WPA2) &&
-	    (priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2)) {
+	    priv->wpa.version == IW_AUTH_WPA_VERSION_WPA2) {

If you look in the archives, you will see that I reject this type of patch all the time.

Also, please use scripts/get_maintainer.pl to determine who to send this to, you used a very old mailing list address that is long dead.

Quoted 8 lines
Quoted 3 lines

thanks,

greg k-h

Thanks for the input. I wasn't sure who to send it to, since the TODO in the driver and the script have different email addresses.

Is there a place to check for inactive mailing lists?

Just trust the get_maintainer.pl script, it knows what to do.

thanks,
greg k-h