Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>
Subsystems (4)
PATCH 1/1 Staging: media: atomisp: include: mmu: include <linux/processor.h> instead of <asm/processor.h>
Fix following checkpatch.pl warning by including
<linux/processor.h> instead of <asm/processor.h>
--- drivers/staging/media/atomisp/include/linux/atomisp_platform.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/atomisp/include/linux/atomisp_platform.h +1 -1
@@ -19,7 +19,7 @@#define ATOMISP_PLATFORM_H_ #include <asm/intel-family.h> -#include <asm/processor.h> +#include <linux/processor.h> #include <linux/i2c.h> #include <media/v4l2-subdev.h>
Signature · 1 line
2.34.1
Quoted 3 lines · Anup Sharma
Fix following checkpatch.pl warning by including
<linux/processor.h> instead of <asm/processor.h>
Missing period at the end. But the entire patch seems unnecessary since it's all about x86, and we have more arch headers there anyway. Anyway it's up to Hans. Also see below.
...
drivers/staging/media/atomisp/include/linux/atomisp_platform.h line 25
Quoted 6 lines
#include <
asm/intel-family.h>drivers/staging/media/atomisp/include/linux/atomisp_platform.h +1
-1-#include <asm/processor.h> +#include <linux/processor.h> #include <linux/i2c.h> #include <media/v4l2-subdev.h>
This seems a bit chaotic with the ordering of the headers here.
...
If you want a good patch, you need to understand what headers are _really_ being used in the header file. Then drop unused, try to compile that and fix all files that will have missing headers after that. This will be a very useful clean up!
Signature · 2 lines
With Best Regards, Andy Shevchenko
Hi,
Quoted 8 lines · Andy Shevchenko
Quoted 3 lines · Anup Sharma
Fix following checkpatch.pl warning by including
<linux/processor.h> instead of <asm/processor.h>Missing period at the end. But the entire patch seems unnecessary since it's all about x86, and we have more arch headers there anyway. Anyway it's up to Hans. Also see below.
Right, given how much real work this driver still needs this really feels like needless churn, so I'm not going to take this patch, sorry.
Regards,
Hans
Quoted 19 lines
...
drivers/staging/media/atomisp/include/linux/atomisp_platform.h line 25
Quoted 6 lines
#include <
asm/intel-family.h>drivers/staging/media/atomisp/include/linux/atomisp_platform.h +1
-1-#include <asm/processor.h> +#include <linux/processor.h> #include <linux/i2c.h> #include <media/v4l2-subdev.h> This seems a bit chaotic with the ordering of the headers here.
...
If you want a good patch, you need to understand what headers are _really_ being used in the header file. Then drop unused, try to compile that and fix all files that will have missing headers after that. This will be a very useful clean up!