Skip to contentSkip to conversation

Using page-fault handler in binder

DISCUSSION Carlos Llamas 2 participants 3 messages Apr 20, 2023 – Apr 21, 2023 Memory management

lore
Share & tools
lore
#0 lore raw

Hi,

I'm trying to remove the current page handling in binder and switch to using ->fault() and other mm/ infrastructure. See, we currently allocate and insert pages manually into vmas, so dropping this boilerplate code seems like a great idea to me. Before starting on this though, I could use some pointers on some of the implementation details.

In binder the messages are not buffered. What happens is that a server task mmaps a region and then allows clients to write their user data directly into this _remote_ vma. This is currently achieved by caching pointers to every page allocated in the server's region.

Instead of caching page pointers, I believe binder could make use of get_user_pages_remote() and trigger a page fault as needed. Basically, implement something similar to access_remote_vm() but that instead does a copy_from_user(). However, I don't see many in-tree users of these routines, so I wonder if I'm overlooking something in this approach?

One more reason for the page caching in binder is being able to free pages from the shrinker's callback. Unused pages are added to an LRU list and we manually zap/free them when they are reclaimed. It is not evident to me how can binder mark a range within the vma region as reclaimable?

Any pointers are appreciated!

--
Carlos Llamas

#1 lore raw
Quoted 14 lines · Carlos Llamas

Hi,

I'm trying to remove the current page handling in binder and switch to using ->fault() and other mm/ infrastructure. See, we currently allocate and insert pages manually into vmas, so dropping this boilerplate code seems like a great idea to me. Before starting on this though, I could use some pointers on some of the implementation details.

In binder the messages are not buffered. What happens is that a server task mmaps a region and then allows clients to write their user data directly into this _remote_ vma. This is currently achieved by caching pointers to every page allocated in the server's region.

Quoted 5 lines

Instead of caching page pointers, I believe binder could make use of get_user_pages_remote() and trigger a page fault as needed. Basically, implement something similar to access_remote_vm() but that instead does a copy_from_user(). However, I don't see many in-tree users of these routines, so I wonder if I'm overlooking something in this approach?

Sounds doable but there might be GUP details I'm missing...

Quoted 6 lines

One more reason for the page caching in binder is being able to free pages from the shrinker's callback. Unused pages are added to an LRU list and we manually zap/free them when they are reclaimed. It is not evident to me how can binder mark a range within the vma region as reclaimable?

I think you would have to release the individual pages using put_page(). Also note that get_user_pages_remote() is being deprecated, see:
https://elixir.bootlin.com/linux/latest/source/mm/gup.c#L2171

Quoted 5 lines

Any pointers are appreciated!

--
Carlos Llamas

#2 lore raw
Quoted 17 lines · Suren Baghdasaryan
Quoted 6 lines · Carlos Llamas

Instead of caching page pointers, I believe binder could make use of get_user_pages_remote() and trigger a page fault as needed. Basically, implement something similar to access_remote_vm() but that instead does a copy_from_user(). However, I don't see many in-tree users of these routines, so I wonder if I'm overlooking something in this approach?

Sounds doable but there might be GUP details I'm missing...

Quoted 6 lines

One more reason for the page caching in binder is being able to free pages from the shrinker's callback. Unused pages are added to an LRU list and we manually zap/free them when they are reclaimed. It is not evident to me how can binder mark a range within the vma region as reclaimable?

Quoted 4 lines

I think you would have to release the individual pages using put_page(). Also note that get_user_pages_remote() is being deprecated, see:
https://elixir.bootlin.com/linux/latest/source/mm/gup.c#L2171

Yeah, I remember reading that comment but it doesn't make sense since the suggested alternatives do not support operations on _remote_ mm.

I actually tracked this down and it seems the original comment was made for get_user_pages() instead, in commit f0818f472d8d ("mm: gup: add get_user_pages_locked and get_user_pages_unlocked"). The whole comment block was then carried over without update into get_user_pages_remote() in commit 1e9877902dc7 ("mm/gup: Introduce get_user_pages_remote()"). The comment block was finally switched to use the "_remote" portion in commit adc8cb406e52 ("mm/gup.c: update the documentation"). In reality, this comment should be relocated to the get_user_pages() section.

Quoted 6 lines
Quoted 6 lines

Any pointers are appreciated!

--
Carlos Llamas