Skip to contentSkip to conversation

staging: rtl8192e: avoid CamelCase <RATRIndex>

PATCH In review John Grace 2 participants 2 messages Apr 25, 2023 – Apr 26, 2023 Staging

lore
Share & tools
lore

John Grace

author
#0 lore raw

PATCH 1/1 staging: rtl8192e: avoid CamelCase <RATRIndex>

Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case.

---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c   | 4 ++--
 drivers/staging/rtl8192e/rtllib.h              | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c      | 4 ++--
 drivers/staging/rtl8192e/rtllib_tx.c           | 6 +++---
 5 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1
index aed53fedeb61..c612e31d1a84 100644
@@ -1008,7 +1008,7 @@ void  rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
 	pdesc->PktSize = skb->len - sizeof(struct tx_fwinfo_8190pci);
 
 	pdesc->SecCAMID = 0;
-	pdesc->RATid = cb_desc->RATRIndex;
+	pdesc->RATid = cb_desc->ratr_index;
 
 
 	pdesc->NoEnc = 1;
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +2 -2
index 27040d1e3230..b58a30d68f2f 100644
@@ -466,7 +466,7 @@ static void _rtl92e_prepare_beacon(struct tasklet_struct *t)
 	tcb_desc = (struct cb_desc *)(pnewskb->cb + 8);
 	tcb_desc->queue_index = BEACON_QUEUE;
 	tcb_desc->data_rate = 2;
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
 	tcb_desc->tx_dis_rate_fallback = 1;
 	tcb_desc->tx_use_drv_assinged_rate = 1;
 	skb_push(pnewskb, priv->rtllib->tx_headroom);
@@ -1440,7 +1440,7 @@ static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
 		return 0;
 	}
 
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
 	tcb_desc->tx_dis_rate_fallback = 1;
 	tcb_desc->tx_use_drv_assinged_rate = 1;
 	tcb_desc->bTxEnableFwCalcDur = 1;
drivers/staging/rtl8192e/rtllib.h +1 -1
index 6e665e866f1f..d5f5ea5615fc 100644
@@ -139,7 +139,7 @@ struct cb_desc {
 	u8 rata_index;
 	u8 queue_index;
 	u16 txbuf_size;
-	u8 RATRIndex;
+	u8 ratr_index;
 	u8 bAMSDU:1;
 	u8 bFromAggrQ:1;
 	u8 reserved6:6;
drivers/staging/rtl8192e/rtllib_softmac.c +2 -2
index b9886e83a6dc..1ca77cdbafa3 100644
@@ -219,7 +219,7 @@ inline void softmac_mgmt_xmit(struct sk_buff *skb, struct rtllib_device *ieee)
 		tcb_desc->queue_index = HIGH_QUEUE;
 
 	tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
 	tcb_desc->tx_dis_rate_fallback = 1;
 	tcb_desc->tx_use_drv_assinged_rate = 1;
 	if (single) {
@@ -297,7 +297,7 @@ softmac_ps_mgmt_xmit(struct sk_buff *skb,
 
 
 	tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
 	tcb_desc->tx_dis_rate_fallback = 1;
 	tcb_desc->tx_use_drv_assinged_rate = 1;
 	if (single) {
drivers/staging/rtl8192e/rtllib_tx.c +3 -3
index 9ab8ee46ef66..54119fba8a57 100644
@@ -486,7 +486,7 @@ static void rtllib_txrate_selectmode(struct rtllib_device *ieee,
 	    !tcb_desc->tx_use_drv_assinged_rate) {
 		if (ieee->iw_mode == IW_MODE_INFRA ||
 		    ieee->iw_mode == IW_MODE_ADHOC)
-			tcb_desc->RATRIndex = 0;
+			tcb_desc->ratr_index = 0;
 	}
 }
 
@@ -892,7 +892,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 				tcb_desc->tx_dis_rate_fallback = 1;
 			}
 
-			tcb_desc->RATRIndex = 7;
+			tcb_desc->ratr_index = 7;
 			tcb_desc->tx_use_drv_assinged_rate = 1;
 		} else {
 			if (is_multicast_ether_addr(header.addr1))
@@ -916,7 +916,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
 					tcb_desc->tx_dis_rate_fallback = 1;
 				}
 
-				tcb_desc->RATRIndex = 7;
+				tcb_desc->ratr_index = 7;
 				tcb_desc->tx_use_drv_assinged_rate = 1;
 				tcb_desc->bdhcp = 1;
 			}
Signature · 1 line
2.39.2
Tested-by on v1 1/1
#1 lore raw
Quoted 106 lines · John Grace

Linux kernel coding-style suggests to not use mixed-case names. Fix checkpatch issue by changing the variable name from camel case to snake case.

---
  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
  drivers/staging/rtl8192e/rtl8192e/rtl_core.c   | 4 ++--
  drivers/staging/rtl8192e/rtllib.h              | 2 +-
  drivers/staging/rtl8192e/rtllib_softmac.c      | 4 ++--
  drivers/staging/rtl8192e/rtllib_tx.c           | 6 +++---
  5 files changed, 9 insertions(+), 9 deletions(-)
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +1 -1
index aed53fedeb61..c612e31d1a84 100644
@@ -1008,7 +1008,7 @@ void  rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc,
  	pdesc->PktSize = skb->len - sizeof(struct tx_fwinfo_8190pci);
 
  	pdesc->SecCAMID = 0;
-	pdesc->RATid = cb_desc->RATRIndex;
+	pdesc->RATid = cb_desc->ratr_index;
 
 
  	pdesc->NoEnc = 1;
drivers/staging/rtl8192e/rtl8192e/rtl_core.c +2 -2
index 27040d1e3230..b58a30d68f2f 100644
@@ -466,7 +466,7 @@ static void _rtl92e_prepare_beacon(struct tasklet_struct *t)
  	tcb_desc = (struct cb_desc *)(pnewskb->cb + 8);
  	tcb_desc->queue_index = BEACON_QUEUE;
  	tcb_desc->data_rate = 2;
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
  	tcb_desc->tx_dis_rate_fallback = 1;
  	tcb_desc->tx_use_drv_assinged_rate = 1;
  	skb_push(pnewskb, priv->rtllib->tx_headroom);
@@ -1440,7 +1440,7 @@ static int _rtl92e_hard_start_xmit(struct sk_buff *skb, struct net_device *dev)
  		return 0;
  	}
 
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
  	tcb_desc->tx_dis_rate_fallback = 1;
  	tcb_desc->tx_use_drv_assinged_rate = 1;
  	tcb_desc->bTxEnableFwCalcDur = 1;
drivers/staging/rtl8192e/rtllib.h +1 -1
index 6e665e866f1f..d5f5ea5615fc 100644
@@ -139,7 +139,7 @@ struct cb_desc {
  	u8 rata_index;
  	u8 queue_index;
  	u16 txbuf_size;
-	u8 RATRIndex;
+	u8 ratr_index;
  	u8 bAMSDU:1;
  	u8 bFromAggrQ:1;
  	u8 reserved6:6;
drivers/staging/rtl8192e/rtllib_softmac.c +2 -2
index b9886e83a6dc..1ca77cdbafa3 100644
@@ -219,7 +219,7 @@ inline void softmac_mgmt_xmit(struct sk_buff *skb, struct rtllib_device *ieee)
  		tcb_desc->queue_index = HIGH_QUEUE;
 
  	tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
  	tcb_desc->tx_dis_rate_fallback = 1;
  	tcb_desc->tx_use_drv_assinged_rate = 1;
  	if (single) {
@@ -297,7 +297,7 @@ softmac_ps_mgmt_xmit(struct sk_buff *skb,
 
 
  	tcb_desc->data_rate = MgntQuery_MgntFrameTxRate(ieee);
-	tcb_desc->RATRIndex = 7;
+	tcb_desc->ratr_index = 7;
  	tcb_desc->tx_dis_rate_fallback = 1;
  	tcb_desc->tx_use_drv_assinged_rate = 1;
  	if (single) {
drivers/staging/rtl8192e/rtllib_tx.c +2 -2
index 9ab8ee46ef66..54119fba8a57 100644
@@ -486,7 +486,7 @@ static void rtllib_txrate_selectmode(struct rtllib_device *ieee,
  	    !tcb_desc->tx_use_drv_assinged_rate) {
  		if (ieee->iw_mode == IW_MODE_INFRA ||
  		    ieee->iw_mode == IW_MODE_ADHOC)
-			tcb_desc->RATRIndex = 0;
+			tcb_desc->ratr_index = 0;
  	}
  }
 
@@ -892,7 +892,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
  				tcb_desc->tx_dis_rate_fallback = 1;
  			}
 
-			tcb_desc->RATRIndex = 7;
+			tcb_desc->ratr_index = 7;
  			tcb_desc->tx_use_drv_assinged_rate = 1;
  		} else {
  			if (is_multicast_ether_addr(header.addr1))

drivers/staging/rtl8192e/rtllib_tx.c static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev) · line 922

Quoted 8 lines
drivers/staging/rtl8192e/rtllib_tx.c +1 -1
@@ -916,7 +916,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev)
  					tcb_desc->tx_dis_rate_fallback = 1;
  				}
 
-				tcb_desc->RATRIndex = 7;
+				tcb_desc->ratr_index = 7;
  				tcb_desc->tx_use_drv_assinged_rate = 1;
  				tcb_desc->bdhcp = 1;
  			}