Skip to contentSkip to conversation

rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <[email protected]> Link: https://github.com/Rust-for-Linux/linux/issues/1002

PATCH In review Roy Matero 2 participants 2 messages Apr 26, 2023 Rust

lore
Share & tools
lore

Roy Matero

author
#0 lore raw

PATCH 1/1 rust: fix sorting of rust/bindings/bindings_helper.h's #includes Suggested by: Miguel Ojeda <[email protected]> Link: https://github.com/Rust-for-Linux/linux/issues/1002

---
 rust/bindings/bindings_helper.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
rust/bindings/bindings_helper.h +2 -2
index 50e7a76d5455..dc8d97272e71 100644
@@ -6,10 +6,10 @@
  * Sorted alphabetically.
  */
 
-#include <linux/slab.h>
 #include <linux/refcount.h>
-#include <linux/wait.h>
 #include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/wait.h>
 
 /* `bindgen` gets confused at certain things. */
 const gfp_t BINDINGS_GFP_KERNEL = GFP_KERNEL;

--
2.40.1

#1 lore raw
Quoted 2 lines · Roy Matero

Thank you for the patch!

Something strange happened -- it looks like the body went into the subject line. Did you use git-send-email?

Also, please use a dash in Suggested-by and a title like "rust:
bindings: sort includes". Also, please add a commit description -- please see Ariel's recent patch [1] and discussion for some more details.

[1] https://lore.kernel.org/rust-for-linux/[email protected]/

Cheers,
Miguel