Input: tests - fix input_test_match_device_id test
Subsystems (2)
Dmitry Torokhov
maintainerPATCH 1/1 Input: tests - fix input_test_match_device_id test
Properly initialize input_device_id structure in input_test_match_device_id test to make sure it contains no garbage causing the test to randomly fail.
Fixes fdefcbdd6f36 ("Input: Add KUnit tests for some of the input core helper functions")
Reported-by Geert Uytterhoeven <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
--- drivers/input/tests/input_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/tests/input_test.c +1 -1
@@ -87,7 +87,7 @@ static void input_test_timestamp(struct kunit *test)static void input_test_match_device_id (struct kunit *test) {struct input_dev *input_dev = test->priv; -struct input_device_id id; +struct input_device_id id = {0 };/* * Must match when the input device bus, vendor, product, version
Signature · 5 lines
2.40.1.495.gc816e09b53d-goog -- Dmitry
Dmitry Torokhov <[email protected]> writes:
Hello Dmitry,
Quoted 8 lines
Properly initialize
input_device_idstructure ininput_test_match_device_idtest to make sure it contains no garbage causing the test to randomly fail.Fixes fdefcbdd6f36 ("Input: Add KUnit tests for some of the input core helper functions")Reported-by Geert Uytterhoeven <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>---
Thanks a lot for fixing this!
Reviewed-by Javier Martinez Canillas <[email protected]>
Signature · 5 lines
Best regards, Javier Martinez Canillas Core Platforms Red Hat
Quoted 7 lines · Dmitry Torokhov
Properly initialize
input_device_idstructure ininput_test_match_device_idtest to make sure it contains no garbage causing the test to randomly fail.Fixes fdefcbdd6f36 ("Input: Add KUnit tests for some of the input core helper functions")Reported-by Geert Uytterhoeven <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>
Tested-by Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds