scsi: megaraid: Use sysfs_emit in show function callsbacks
Subsystems (2)
PATCH 1/1 scsi: megaraid: Use sysfs_emit in show function callsbacks
As stated in the Documentation/filesystems/sysfs.rst file, it is recommended that the show() callback function for kobject attributes strictly utilizes sysfs_emit instead of the sprintf family of functions.
Issue identified using the coccinelle device_attr_show.cocci script.
Signed-off-by Anup Sharma <[email protected]>
--- drivers/scsi/megaraid/megaraid_sas_base.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-)
drivers/scsi/megaraid/megaraid_sas_base.c +8 -7
@@ -3335,7 +3335,7 @@ fw_crash_buffer_size_show(struct device *cdev,struct megasas_instance *instance = (struct megasas_instance *) shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%ld\n" , (unsigned long ) +return sysfs_emit (buf,"%ld\n" , (unsigned long ) ((instance->fw_crash_buffer_size) *1024 *1024 )/PAGE_SIZE ); }
@@ -3382,14 +3382,14 @@ fw_crash_state_show(struct device *cdev,struct megasas_instance *instance = (struct megasas_instance *) shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%d\n" , instance->fw_crash_state); +return sysfs_emit (buf,"%d\n" , instance->fw_crash_state); }static ssize_t page_size_show (struct device *cdev,struct device_attribute *attr,char *buf) { -return snprintf (buf,PAGE_SIZE ,"%ld\n" , (unsigned long )PAGE_SIZE -1 ); +return sysfs_emit (buf,"%ld\n" , (unsigned long )PAGE_SIZE -1 ); } static ssize_t
@@ -3399,7 +3399,7 @@ ldio_outstanding_show(struct device *cdev, struct device_attribute *attr,struct Scsi_Host *shost =class_to_shost (cdev);struct megasas_instance *instance = (struct megasas_instance *)shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&instance->ldio_outstanding)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&instance->ldio_outstanding)); } static ssize_t
@@ -3409,7 +3409,7 @@ fw_cmds_outstanding_show(struct device *cdev,struct Scsi_Host *shost =class_to_shost (cdev);struct megasas_instance *instance = (struct megasas_instance *)shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%d\n" ,atomic_read (&instance->fw_outstanding)); +return sysfs_emit (buf,"%d\n" ,atomic_read (&instance->fw_outstanding)); } static ssize_t
@@ -3419,7 +3419,8 @@ enable_sdev_max_qd_show(struct device *cdev,struct Scsi_Host *shost =class_to_shost (cdev);struct megasas_instance *instance = (struct megasas_instance *)shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%d\n" , instance->enable_sdev_max_qd); +return sysfs_emit (buf,"%d\n" , + instance->enable_sdev_max_qd); } static ssize_t
@@ -3473,7 +3474,7 @@ raid_map_id_show(struct device *cdev, struct device_attribute *attr,struct megasas_instance *instance = (struct megasas_instance *)shost->hostdata; -return snprintf (buf,PAGE_SIZE ,"%ld\n" , +return sysfs_emit (buf,"%ld\n" , (unsigned long )instance->map_id); }
Signature · 1 line
2.34.1