media: venus: hfi_cmds: Replace fake flex-arrays with flexible-array members
Subsystems (4)
PATCH 1/1 media: venus: hfi_cmds: Replace fake flex-arrays with flexible-array members
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element arrays with flexible-array members in multiple structures.
This helps with the ongoing efforts to tighten the FORTIFY_SOURCE routines on memcpy() and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].
This results in no differences in binary output.
--- drivers/media/platform/qcom/venus/hfi_cmds.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/qcom/venus/hfi_cmds.h +4 -4
@@ -82,7 +82,7 @@ struct hfi_sys_set_buffers_pkt {u32 buffer_type;u32 buffer_size;u32 num_buffers; -u32 buffer_addr[1 ]; +u32 buffer_addr[]; };struct hfi_sys_ping_pkt {
@@ -177,7 +177,7 @@ struct hfi_session_empty_buffer_uncompressed_plane1_pkt {u32 filled_len;u32 offset;u32 packet_buffer2; -u32 data[1 ]; +u32 data[]; };struct hfi_session_empty_buffer_uncompressed_plane2_pkt {
@@ -186,7 +186,7 @@ struct hfi_session_empty_buffer_uncompressed_plane2_pkt {u32 filled_len;u32 offset;u32 packet_buffer3; -u32 data[1 ]; +u32 data[]; };struct hfi_session_fill_buffer_pkt {
@@ -227,7 +227,7 @@ struct hfi_session_release_buffer_pkt {u32 extradata_size;u32 response_req;u32 num_buffers; -u32 buffer_info[1 ]; +u32 buffer_info[]; };struct hfi_session_release_resources_pkt {
Signature · 1 line
2.34.1
Quoted 8 lines · Gustavo A. R. Silva
One-element arrays are deprecated, and we are replacing them with flexible array members instead. So, replace one-element arrays with flexible-array members in multiple structures.
This helps with the ongoing efforts to tighten the
FORTIFY_SOURCEroutines onmemcpy()and help us make progress towards globally enabling -fstrict-flex-arrays=3 [1].
Quoted 6 lines
This results in no differences in binary output.
The subject is very close to the related patch (plural vs non-plural):
https://lore.kernel.org/all/e4b13d7b79d1477e775c6d4564f7b23c4cf967f2.1684278538.git.gustavoars@kernel.org/
So it might be nice to name struct hfi_session_set_buffers_pkt specifically in the other patch's subject, but otherwise:
Signature · 1 line
Kees Cook