selftests/bpf: specify expected instructions in test_verifier tests
Hello Eduard Zingerman,
This is a semi-automatic email about new static checker warnings.
The patch 933ff53191eb: "selftests/bpf: specify expected instructions in test_verifier tests" from Jun 21, 2022, leads to the following Smatch complaint:
./tools/testing/selftests/bpf/test_verifier.c:1365 get_xlated_program()
warn: variable dereferenced before check 'buf' (see line 1364)
./tools/testing/selftests/bpf/test_verifier.c
1363 *cnt = xlated_prog_len / buf_element_size;
1364 *buf = calloc(*cnt, buf_element_size);
1365 if (!buf) {
This should be if (!*buf) {
1366 perror("can't allocate xlated program buffer");
1367 return -ENOMEM;regards,
dan carpenter
Eduard Zingerman
maintainerQuoted 16 lines · Dan Carpenter
Hello Eduard Zingerman,
This is a semi-automatic email about new static checker warnings.
The patch
933ff53191eb: "selftests/bpf: specify expected instructions intest_verifiertests" from Jun 21, 2022, leads to the following Smatch complaint:
./tools/testing/selftests/bpf/test_verifier.c:1365get_xlated_program()
warn: variable dereferenced before check 'buf' (see line 1364)
./tools/testing/selftests/bpf/test_verifier.c
1363 *cnt =xlated_prog_len/buf_element_size;
1364 *buf =calloc(*cnt, buf_element_size);
1365 if (!buf) {
Quoted 4 lines
This should be if (!*buf) {
1366 perror("can't allocate xlated program buffer"); 1367 return -ENOMEM;
Hi Dan,
Thank you for this bug report, I'll submit a fixed version.
Thanks,
Eduard
Quoted 3 lines
regards,
dan carpenter