KVM: selftests: Provide generic way to read system counter
A message that is not in the archive (sent off-list or not yet received): [email protected]
Thanks for looking at this again. I'm glad to know there is still interest in upstreaming it. It fell off my radar and other things took priority.
Quoted 13 lines · Sean Christopherson
Quoted 1 line · Colton Lewis
+uint64_t
cycles_read(void);I would prefer something like
get_system_counter()orread_system_counter()Pairing "read" after "cycles" can be read (lol) in past tense or current tense, e.g. "the number of cycles that were read" versus "read the current number of cycles". I usedguest_system_counter_read()in an example in v1[*], but that was just me copy+pasting from the patch.And "cycles" is typically used to describe latency and elapsed time, e.g. doing
uint64_t time = cycles_to_ns(cycles_read());
Quoted 7 lines
looks valid at a glance, e.g. "convert that number of cycles that were read into nanoseconds", but is nonsensical in most cases because it's current tense, and there's no baseline time.
Sorry for not bringing this up in v2, I think I only looked at the implementation.
I'll change to get_system_counter_ordered() as Oliver suggests.
Quoted 19 lines
Quoted 19 lines
(quoted diff) +5
-0+uint64_t cycles_to_ns(struct kvm_vcpu *vcpu, uint64_t cycles) +{ + TEST_ASSERT(cycles < 10000000000, "Conversion to ns may overflow"); + return cycles * NSEC_PER_SEC / timer_get_cntfrq(); +}tools/testing/selftests/kvm/lib/x86_64/processor.c +6
-0@@ -1270,3 +1270,16 @@ void kvm_selftest_arch_init(void) host_cpu_is_intel =this_cpu_is_intel (); host_cpu_is_amd =this_cpu_is_amd (); } + +uint64_t cycles_read (void ) +{ +return rdtsc (); +} +
Quoted 8 lines
tools/testing/selftests/kvm/lib/x86_64/processor.c void kvm_selftest_arch_init(void) · line 1283
Quoted 5 lines
tools/testing/selftests/kvm/lib/x86_64/processor.c +5
-0+uint64_t cycles_to_ns (struct kvm_vcpu *vcpu,uint64_t cycles) +{ +uint64_t tsc_khz =__vcpu_ioctl (vcpu,KVM_GET_TSC_KHZ ,NULL ); + +TEST_ASSERT (cycles <10000000000 ,"Conversion to ns may overflow" );Is it possible to calculate this programatically instead of hardcoding a magic number?
It is. Unsure why I didn't do it before.