Skip to contentSkip to conversation

dt-bindings: updated max-link-speed for newer generations

PATCH Ben Dooks 1 participant 1 message Jun 6, 2023 1 message not in the archive PCI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): ZHeZxPRGw+X83V1k@bhelgaas

Ben Dooks

author
#1 lore raw
Quoted 34 lines · Bjorn Helgaas

Possible subject:

dt-bindings: Add gen5, gen6 max-link-speed values

Quoted 15 lines · Ben Dooks

Add updated max-link-speed values for newer generation PCIe link speeds.

---
  Documentation/devicetree/bindings/pci/pci.txt | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/pci/pci.txt +0 -0
index 6a8f2874a24d..56391e193fc4 100644

Documentation/devicetree/bindings/pci/pci.txt driver implementation may support the following properties: · line 27

Quoted 8 lines
Documentation/devicetree/bindings/pci/pci.txt +3 -2
@@ -22,8 +22,9 @@ driver implementation may support the following properties:
     If present this property specifies PCI gen for link capability.  Host
     drivers could add this as a strategy to avoid unnecessary operation for
     unsupported link speed, for instance, trying to do training for
-   unsupported link speed, etc.  Must be '4' for gen4, '3' for gen3, '2'
-   for gen2, and '1' for gen1. Any other values are invalid.
+   unsupported link speed, etc.  Must be '6' for gen6,  '5' for gen5,
+   '4' for gen4, '3' for gen3, '2' for gen2, and '1' for gen1.
+   Any other values are invalid.

I really wish we'd used values with some connection to the actual speed, e.g., "16" for 16 GT/s. These "gen X" values are a real hassle to convert back to the speed. But I guess that's water under the bridge.

Quoted 8 lines

Maybe we should annotate the documentation here, though, e.g.,

   '6' for gen6 (64.0 GT/s), '5' for gen5 (32.0 GT/s), ...

Do I have that right? I don't see "gen5" etc in the specs themselves, so this is just based on Google.

Bjorn

I checked the wikipedia, I've been working on a yet-to-be-released device that uses a gen5 phy so updating this would be useful.

Signature · 4 lines
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html