Skip to contentSkip to conversation

staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps

PATCH In review Tree Davies 3 participants 3 messages Jun 27, 2023 – Jul 27, 2023 Staging

lore
Share & tools
lore

Tree Davies

author
#0 lore raw

PATCH v3 1/1 staging: rtl8192e: Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps

Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to fix checkpatch warning: Avoid CamelCase

Signed-off-by Tree Davies <[email protected]>

---
v3: Fix email parch as v2 info was placed above the ---
v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps

 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1
index f9fa3f2bb728..d09342dde61d 100644
@@ -139,7 +139,7 @@ u16  TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
 	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
 }
 
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee)
 {
 	bool			retValue = false;
 	struct rtllib_network *net = &ieee->current_network;
drivers/staging/rtl8192e/rtllib.h +1 -1
index e3ce4431d460..293eb9315d99 100644
@@ -2003,7 +2003,7 @@ extern u8 MCS_FILTER_ALL[];
 extern u16 MCS_DATA_RATE[2][2][77];
 u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame);
 void HTResetIOTSetting(struct rt_hi_throughput *ht_info);
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee);
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee);
 u16  TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate);
 int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb);
 int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb);
drivers/staging/rtl8192e/rtllib_softmac.c +1 -1
index 425d4acbcdf0..05740e90d1c6 100644
@@ -2224,7 +2224,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device *ieee, struct sk_buff *skb)
 		ieee->softmac_stats.rx_auth_rs_ok++;
 		if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) {
 			if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) {
-				if (IsHTHalfNmodeAPs(ieee)) {
+				if (is_ht_half_nmode_aps(ieee)) {
 					bSupportNmode = true;
 					bHalfSupportNmode = true;
 				} else {
Signature · 1 line
2.39.2
Tested-by on v3 1/1
#1 lore raw
Quoted 12 lines · Tree Davies

Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to fix checkpatch warning: Avoid CamelCase

Signed-off-by Tree Davies <[email protected]>

---
v3: Fix email parch as v2 info was placed above the ---
v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps

  drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
  drivers/staging/rtl8192e/rtllib.h         | 2 +-
  drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
  3 files changed, 3 insertions(+), 3 deletions(-)
Tested-by Philipp Hortmann <[email protected]>
maintainer
#2 lore raw
In reply to Tree Davies
Quoted 17 lines · Tree Davies

Rename function IsHTHalfNmodeAPs to is_ht_half_nmode_aps in order to fix checkpatch warning: Avoid CamelCase

Signed-off-by Tree Davies <[email protected]>

---
v3: Fix email parch as v2 info was placed above the ---
v2: Rename is_ht_half_nmode_a_ps -> is_ht_half_nmode_aps

 drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
 drivers/staging/rtl8192e/rtllib.h         | 2 +-
 drivers/staging/rtl8192e/rtllib_softmac.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +0 -0
index f9fa3f2bb728..d09342dde61d 100644

drivers/staging/rtl8192e/rtl819x_HTProc.c u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate) · line 142

Quoted 5 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1
@@ -139,7 +139,7 @@ u16  TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate)
 	return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf];
 }
 
-bool IsHTHalfNmodeAPs(struct rtllib_device *ieee)
+bool is_ht_half_nmode_aps(struct rtllib_device *ieee)

As this is a global symbol, can you please prefix it with the driver name so that the global symbol table looks semi-sane?

Perhaps rtllib_is_ht_half_nmode_aps()?

thanks,

greg k-h