HID: input: fix mapping for camera access keys
PATCH 1/1 HID: input: fix mapping for camera access keys
Commit 9f4211bf7f81 ("HID: add mapping for camera access keys") added mapping for the camera access keys, but unfortunately used wrong usage codes for them. HUTRR72[1] specifies that camera access controls use 0x76, 0x077 and 0x78 usages in the consumer control page. Previously mapped 0xd5, 0xd6 and 0xd7 usages are actually defined in HUTRR64[2] as game recording controls.
[1] https://www.usb.org/sites/default/files/hutrr72_-_usages_to_control_camera_access_0.pdf
[2] https://www.usb.org/sites/default/files/hutrr64b_-_game_recording_controllers_0.pdf
--- drivers/hid/hid-input.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/hid/hid-input.c +4 -3
@@ -1085,6 +1085,10 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase 0x074 :map_key_clear (KEY_BRIGHTNESS_MAX );break ;case 0x075 :map_key_clear (KEY_BRIGHTNESS_AUTO );break ; +case 0x076 :map_key_clear (KEY_CAMERA_ACCESS_ENABLE );break ; +case 0x077 :map_key_clear (KEY_CAMERA_ACCESS_DISABLE );break ; +case 0x078 :map_key_clear (KEY_CAMERA_ACCESS_TOGGLE );break ; +case 0x079 :map_key_clear (KEY_KBDILLUMUP );break ;case 0x07a :map_key_clear (KEY_KBDILLUMDOWN );break ;case 0x07c :map_key_clear (KEY_KBDILLUMTOGGLE );break ;
@@ -1131,9 +1135,6 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fielcase 0x0cd :map_key_clear (KEY_PLAYPAUSE );break ;case 0x0cf :map_key_clear (KEY_VOICECOMMAND );break ; -case 0x0d5 :map_key_clear (KEY_CAMERA_ACCESS_ENABLE );break ; -case 0x0d6 :map_key_clear (KEY_CAMERA_ACCESS_DISABLE );break ; -case 0x0d7 :map_key_clear (KEY_CAMERA_ACCESS_TOGGLE );break ;case 0x0d8 :map_key_clear (KEY_DICTATE );break ;case 0x0d9 :map_key_clear (KEY_EMOJI_PICKER );break ;
Signature · 5 lines
2.41.0.178.g377b9f9a00-goog -- Dmitry
Quoted 8 lines · Dmitry Torokhov
Commit
9f4211bf7f81("HID: add mapping for camera access keys") added mapping for the camera access keys, but unfortunately used wrong usage codes for them. HUTRR72[1] specifies that camera access controls use0x76,0x077and0x78usages in the consumer control page. Previously mapped0xd5,0xd6and0xd7usages are actually defined in HUTRR64[2] as game recording controls.[...]
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.5/upstream-fixes), thanks!
[1/1] HID: input: fix mapping for camera access keys
https://git.kernel.org/hid/hid/c/e3ea6467f623
Cheers,
Signature · 1 line
Benjamin Tissoires <[email protected]>