media: venus: Use struct_size_t() helper in pkt_session_unset_buffers()
Subsystems (4)
PATCH 1/1 media: venus: Use struct_size_t() helper in pkt_session_unset_buffers()
Prefer struct_size_t() over struct_size() when no pointer instance of the structure type is present.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/qcom/venus/hfi_cmds.c +2 -2
@@ -251,8 +251,8 @@ int pkt_session_unset_buffers(struct hfi_session_release_buffer_pkt *pkt, pkt->extradata_size =0 ; pkt->shdr.hdr.size = -struct_size ((struct hfi_session_set_buffers_pkt *)0 , - buffer_info, bd->num_buffers); + struct_size_t(struct hfi_session_set_buffers_pkt, + buffer_info, bd->num_buffers); } pkt->response_req = bd->response_required;
Signature · 1 line
2.34.1
Quoted 4 lines · Gustavo A. R. Silva
Prefer
struct_size_t()overstruct_size()when no pointer instance of the structure type is present.Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Vikash Garodia <[email protected]>
Quoted 19 lines
--- drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/qcom/venus/hfi_cmds.c +2
-2@@ -251,8 +251,8 @@ int pkt_session_unset_buffers(struct hfi_session_release_buffer_pkt *pkt, pkt->extradata_size =0 ; pkt->shdr.hdr.size = -struct_size ((struct hfi_session_set_buffers_pkt *)0 , - buffer_info, bd->num_buffers); + struct_size_t(struct hfi_session_set_buffers_pkt, + buffer_info, bd->num_buffers); } pkt->response_req = bd->response_required;
Kees Cook
AppliedQuoted 2 lines · Gustavo A. R. Silva
Prefer
struct_size_t()overstruct_size()when no pointer instance of the structure type is present.
Applied to for-linus/hardening, thanks!
[1/1] media: venus: Use struct_size_t() helper in pkt_session_unset_buffers()
https://git.kernel.org/kees/c/cdddb626dc05
Take care,
Signature · 1 line
Kees Cook