RDMA/irdma: Replace one-element array with flexible-array member
Subsystems (2)
PATCH 1/1 RDMA/irdma: Replace one-element array with flexible-array member
One-element and zero-length arrays are deprecated. So, replace one-element array in struct irdma_qvlist_info with flexible-array member.
A patch for this was sent a while ago[1]. However, it seems that, at the time, the changes were partially folded[2][3], and the actual flexible-array transformation was omitted. This patch fixes that.
The only binary difference seen before/after changes is shown below:
| drivers/infiniband/hw/irdma/hw.o | @@ -868,7 +868,7 @@ | drivers/infiniband/hw/irdma/hw.c:484 (discriminator 2) | size += struct_size(iw_qvlist, qv_info, rf->msix_count); | 55b: imul $0x45c,%rdi,%rdi |- 562: add $0x10,%rdi |+ 562: add $0x4,%rdi
which is, of course, expected as it reflects the mistake made while folding the patch I've mentioned above.
Worth mentioning is the fact that with this change we save 12 bytes of memory, as can be inferred from the diff snapshot above. Notice that:
$ pahole -C rdma_qv_info idrivers/infiniband/hw/irdma/hw.o
struct irdma_qv_info {
u32 v_idx; /* 0 4 */
u16 ceq_idx; /* 4 2 */
u16 aeq_idx; /* 6 2 */
u8 itr_idx; /* 8 1 *//* size: 12, cachelines: 1, members: 4 */ /* padding: 3 */ /* last cacheline: 12 bytes */ };
--- drivers/infiniband/hw/irdma/main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/irdma/main.h +1 -1
@@ -239,7 +239,7 @@ struct irdma_qv_info {struct irdma_qvlist_info {u32 num_vectors; -struct irdma_qv_info qv_info[1 ]; +struct irdma_qv_info qv_info[]; };struct irdma_gen_ops {
Signature · 1 line
2.34.1
Leon Romanovsky
AppliedQuoted 9 lines · Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace one-element array in struct
irdma_qvlist_infowith flexible-array member.A patch for this was sent a while ago[1]. However, it seems that, at the time, the changes were partially folded[2][3], and the actual flexible-array transformation was omitted. This patch fixes that.
[...]
Applied, thanks!
[1/1] RDMA/irdma: Replace one-element array with flexible-array member
https://git.kernel.org/rdma/rdma/c/38313c6d2a02c2
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>
Quoted 6 lines · Leon Romanovsky
Quoted 4 lines · Gustavo A. R. Silva
One-element and zero-length arrays are deprecated. So, replace one-element array in struct
irdma_qvlist_infowith flexible-array member.
Quoted 7 lines
Quoted 5 lines
A patch for this was sent a while ago[1]. However, it seems that, at the time, the changes were partially folded[2][3], and the actual flexible-array transformation was omitted. This patch fixes that.
[...]
Applied, thanks!
Awesome. :)
Thank you!
--
Gustavo
Quoted 5 lines
[1/1] RDMA/irdma: Replace one-element array with flexible-array member
https://git.kernel.org/rdma/rdma/c/38313c6d2a02c2Best regards,