Skip to contentSkip to conversation

lsm: add comment block for security_sk_classify_flow() LSM hook

PATCH In review Khadija Kamran 2 participants 3 messages Aug 7, 2023 – Aug 8, 2023 Security (LSM)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 lsm: add comment block for security_sk_classify_flow() LSM hook

security_sk_classify_flow() LSM hook has no comment block. Add a comment block with a brief description of LSM hook and its function parameters.

---
Changed in v2:
- Add parenthesis with security_sk_calssify_flow to refer to it as a function in commit message and commit log.
- Remove an extra space in the comment block.

security/security.c | 7 +++++++

 1 file changed, 7 insertions(+)
security/security.c +7 -0
index d5ff7ff45b77..b76fb27a1dc6 100644
@@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, struct sock *newsk)
 }
 EXPORT_SYMBOL(security_sk_clone);
 
+/**
+ * security_sk_classify_flow() - Set a flow's secid based on socket
+ * @sk: original socket
+ * @flic: target flow
+ *
+ * Set the target flow's secid to socket's secid.
+ */
 void security_sk_classify_flow(struct sock *sk, struct flowi_common *flic)
 {
 	call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 5 lines · Khadija Kamran

security_sk_classify_flow() LSM hook has no comment block. Add a comment block with a brief description of LSM hook and its function parameters.

Quoted 8 lines

---
Changed in v2:
- Add parenthesis with security_sk_calssify_flow to refer to it as a function in commit message and commit log.
- Remove an extra space in the comment block.

security/security.c | 7 +++++++

 1 file changed, 7 insertions(+)

Hi Khadija,

Thanks, but I already merged your original patch :)

https://lore.kernel.org/linux-security-module/[email protected]/

Quoted 20 lines
security/security.c +7 -1
index d5ff7ff45b77..b76fb27a1dc6 100644
@@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, struct sock *newsk)
 }
 EXPORT_SYMBOL(security_sk_clone);
 
+/**
+ * security_sk_classify_flow() - Set a flow's secid based on socket
+ * @sk: original socket
+ * @flic: target flow
+ *
+ * Set the target flow's secid to socket's secid.
+ */
 void security_sk_classify_flow(struct sock *sk, struct flowi_common *flic)
 {
        call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
--

2.34.1

Signature · 1 line
paul-moore.com
#2 lore raw
Quoted 12 lines · Paul Moore
Quoted 11 lines · Khadija Kamran

security_sk_classify_flow() LSM hook has no comment block. Add a comment block with a brief description of LSM hook and its function parameters.

---
Changed in v2:
- Add parenthesis with security_sk_calssify_flow to refer to it as a function in commit message and commit log.
- Remove an extra space in the comment block.

Quoted 8 lines
Quoted 2 lines

security/security.c | 7 +++++++

 1 file changed, 7 insertions(+)

Hi Khadija,

Thanks, but I already merged your original patch :)

https://lore.kernel.org/linux-security-module/[email protected]/

Hey Paul,

Great. Thank you. :)

Regards,
Khadija

Quoted 24 lines
Quoted 21 lines
security/security.c +7 -1
index d5ff7ff45b77..b76fb27a1dc6 100644
@@ -4396,6 +4396,13 @@ void security_sk_clone(const struct sock *sk, struct sock *newsk)
 }
 EXPORT_SYMBOL(security_sk_clone);
 
+/**
+ * security_sk_classify_flow() - Set a flow's secid based on socket
+ * @sk: original socket
+ * @flic: target flow
+ *
+ * Set the target flow's secid to socket's secid.
+ */
 void security_sk_classify_flow(struct sock *sk, struct flowi_common *flic)
 {
        call_void_hook(sk_getsecid, sk, &flic->flowic_secid);
--

2.34.1

Signature · 1 line
paul-moore.com