Skip to contentSkip to conversation

Adding a driver for the INA260 chip of Texas Instrument. It follows the hardware monitoring kernel API.

PATCH In review Loic Guegan 3 participants 3 messages Aug 15, 2023 – Aug 16, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Adding a driver for the INA260 chip of Texas Instrument. It follows the hardware monitoring kernel API.

---
 drivers/staging/Kconfig         |   2 +
 drivers/staging/Makefile        |   1 +
 drivers/staging/ina260/Kconfig  |   6 +
 drivers/staging/ina260/Makefile |   6 +
 drivers/staging/ina260/TODO     |   2 +
 drivers/staging/ina260/ina260.c | 261 ++++++++++++++++++++++++++++++++
 6 files changed, 278 insertions(+)
 create mode 100644 drivers/staging/ina260/Kconfig
 create mode 100644 drivers/staging/ina260/Makefile
 create mode 100644 drivers/staging/ina260/TODO
 create mode 100755 drivers/staging/ina260/ina260.c
drivers/staging/Kconfig +2 -0
index f9aef39ca..e173e4353 100644
@@ -78,4 +78,6 @@ source "drivers/staging/qlge/Kconfig"
 
 source "drivers/staging/vme_user/Kconfig"
 
+source "drivers/staging/ina260/Kconfig"
+
 endif # STAGING
drivers/staging/Makefile +1 -0
index ffa70dda4..a1d7e1ddb 100644
@@ -28,3 +28,4 @@ obj-$(CONFIG_PI433)		+= pi433/
 obj-$(CONFIG_XIL_AXIS_FIFO)	+= axis-fifo/
 obj-$(CONFIG_FIELDBUS_DEV)     += fieldbus/
 obj-$(CONFIG_QLGE)		+= qlge/
+obj-$(CONFIG_INA260)		+= ina260/
\ No newline at end of file
drivers/staging/ina260/Kconfig new file +6 -0
new file mode 100644
index 000000000..e873abc9d
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+config INA260
+	tristate "Support for INA260 Power Monitoring i2c chip"
+	depends on I2C && REGMAP_I2C
+	help
+	  Support for the Texas Instrument INA260 power monitoring chip with precision integrated shunt.
drivers/staging/ina260/Makefile new file +6 -0
new file mode 100644
index 000000000..d4eeba95e
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for the Texas Instruments INA260 drivers
+#
+
+obj-$(CONFIG_INA260) += ina260.o
drivers/staging/ina260/TODO new file +2 -0
new file mode 100644
index 000000000..2ed5b80c3
@@ -0,0 +1,2 @@
+Created on: 15 August 2023
+Contact: Loic GUEGAN <[email protected]>
\ No newline at end of file
drivers/staging/ina260/ina260.c new file +261 -0

261 lines not on this page · raw message

Signature · 1 line
2.41.0
maintainer
#1 lore raw
Quoted 1 line · Loic Guegan

Subject and description are all wrong. I would suggest to read and understand the documentation in Documentation/process as well as Documentation/hwmon/submitting-patches.rst before resubmitting.

Quoted 7 lines
---
 drivers/staging/Kconfig         |   2 +
 drivers/staging/Makefile        |   1 +
 drivers/staging/ina260/Kconfig  |   6 +
 drivers/staging/ina260/Makefile |   6 +
 drivers/staging/ina260/TODO     |   2 +
 drivers/staging/ina260/ina260.c | 261 ++++++++++++++++++++++++++++++++

No hwmon patches in drivers/staging/, please.

Quoted 85 lines
 6 files changed, 278 insertions(+)
 create mode 100644 drivers/staging/ina260/Kconfig
 create mode 100644 drivers/staging/ina260/Makefile
 create mode 100644 drivers/staging/ina260/TODO
 create mode 100755 drivers/staging/ina260/ina260.c
drivers/staging/Kconfig +2 -0
index f9aef39ca..e173e4353 100644
@@ -78,4 +78,6 @@ source "drivers/staging/qlge/Kconfig"
 
 source "drivers/staging/vme_user/Kconfig"
 
+source "drivers/staging/ina260/Kconfig"
+
 endif # STAGING
drivers/staging/Makefile +1 -0
index ffa70dda4..a1d7e1ddb 100644
@@ -28,3 +28,4 @@ obj-$(CONFIG_PI433)		+= pi433/
 obj-$(CONFIG_XIL_AXIS_FIFO)	+= axis-fifo/
 obj-$(CONFIG_FIELDBUS_DEV)     += fieldbus/
 obj-$(CONFIG_QLGE)		+= qlge/
+obj-$(CONFIG_INA260)		+= ina260/
\ No newline at end of file
drivers/staging/ina260/Kconfig new file +6 -0
new file mode 100644
index 000000000..e873abc9d
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+config INA260
+	tristate "Support for INA260 Power Monitoring i2c chip"
+	depends on I2C && REGMAP_I2C
+	help
+	  Support for the Texas Instrument INA260 power monitoring chip with precision integrated shunt.
drivers/staging/ina260/Makefile new file +6 -0
new file mode 100644
index 000000000..d4eeba95e
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+# Makefile for the Texas Instruments INA260 drivers
+#
+
+obj-$(CONFIG_INA260) += ina260.o
drivers/staging/ina260/TODO new file +2 -0
new file mode 100644
index 000000000..2ed5b80c3
@@ -0,0 +1,2 @@
+Created on: 15 August 2023
+Contact: Loic GUEGAN <[email protected]>
\ No newline at end of file
drivers/staging/ina260/ina260.c new file +19 -0
new file mode 100755
index 000000000..f827236b8
@@ -0,0 +1,261 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Driver for Texas Instruments INA260 power monitor chip
+ * with precision integrated shunt.
+ * Datasheet: https://www.ti.com/lit/gpn/INA260
+ *
+ * Copyright (C) 2023 GUEGAN Loic <[email protected]>
+ */
+
+#include "linux/module.h"
+#include "linux/uaccess.h"
+#include "linux/i2c.h"
+#include "linux/kobject.h"
+#include "linux/slab.h"
+#include "linux/kernel.h"
+#include <linux/sysfs.h>
+#include <linux/hwmon.h>
+#include <linux/regmap.h>
+

drivers/staging/ina260/ina260.c line 29

Quoted 10 lines
drivers/staging/ina260/ina260.c new file +10 -0
+// INA260 registers
+#define INA260_REG_CONFIGURATION  0x00
+#define INA260_REG_CURRENT        0x01
+#define INA260_REG_VOLTAGE        0x02
+#define INA260_REG_POWER          0x03
+#define INA260_REG_MASKENABLE     0x06
+#define INA260_REG_ALERTLIMIT     0x07
+#define INA260_REG_MANUFACTURER   0xFE
+#define INA260_REG_DIE            0xFF
+

The register map is very much identical to ina219, ina220, ina226, ina230, and ina231, all of which are supported by drivers/hwmon/ina2xx.c. Please consider adding support for ina260 to that driver.

Guenter

#2 lore raw
Quoted 7 lines · Guenter Roeck
Quoted 1 line · Loic Guegan

Subject and description are all wrong. I would suggest to read and understand the documentation in Documentation/process as well as Documentation/hwmon/submitting-patches.rst before resubmitting.

And when submitting patches, do not GPG-sign them like ordinary emails, but rather use patatt instead.

Signature · 1 line
An old man doll... just what I always wanted! - Clara